Skip to content

Commit 9b253ff

Browse files
authored
V2.3.2 (#620)
* Refactor camera component to ./src/camera - Refactor camera component to ./src/camera from ./src/html5-qrcode.ts * Misc fixes (codacy) * Codacy fixes * (refactor) Abstract camera selection UI to a separate class * Add support for zoom slider And misc changes. * misc fixes. * Misc changes per PR comments. * Update change log + codacy fix. * Update html5-qrcode.min.js * Add unit test for camera-selection-ui and camera-zoom-ui * Refactor TorchButton and remove html5qrcode deps To make it feasible to test the class. * Create torch-button.test.ts * Update torch-button.test.ts * Make supportedScanTypes optional.
1 parent 47ebd5a commit 9b253ff

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ interface Html5QrcodeScannerConfig
554554
* - [SCAN_TYPE_FILE] - Only file based scan supported.
555555
* - Setting wrong values or multiple values will fail.
556556
*/
557-
supportedScanTypes: Array<Html5QrcodeScanType> | [];
557+
supportedScanTypes?: Array<Html5QrcodeScanType> | [];
558558

559559
/**
560560
* If {@code true} the rendered UI will have button to turn flash on or off

minified/html5-qrcode.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/html5-qrcode-scanner.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ interface Html5QrcodeScannerConfig
114114
* - [SCAN_TYPE_FILE] - Only file based scan supported.
115115
* - Setting wrong values or multiple values will fail.
116116
*/
117-
supportedScanTypes: Array<Html5QrcodeScanType> | [];
117+
supportedScanTypes?: Array<Html5QrcodeScanType> | [];
118118

119119
/**
120120
* If {@code true} the rendered UI will have button to turn flash on or off

src/ui/scanner/scan-type-selector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
export class ScanTypeSelector {
1818
private supportedScanTypes: Array<Html5QrcodeScanType>;
1919

20-
constructor(supportedScanTypes: Array<Html5QrcodeScanType> | []) {
20+
constructor(supportedScanTypes?: Array<Html5QrcodeScanType> | []) {
2121
this.supportedScanTypes = this.validateAndReturnScanTypes(
2222
supportedScanTypes);
2323
}

0 commit comments

Comments
 (0)