Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring specific CHT instances for provisioned alerts #97

Open
jkuester opened this issue Apr 2, 2024 · 4 comments
Open

Support ignoring specific CHT instances for provisioned alerts #97

jkuester opened this issue Apr 2, 2024 · 4 comments
Assignees

Comments

@jkuester
Copy link
Collaborator

jkuester commented Apr 2, 2024

To get the most value from alerts, noise reduction is essential. When monitoring CHT multiple instances, it may be helpful to only receive alerts for some of the instances, while other instances (e.g. training instances) do not trigger alerts.

Grafana alerts are highly customizable and you can tweak all kinds of factors on when to send a custom alert (and what instances it should trigger for). However, our provisioned alerts cannot be edited. If someone wants to not trigger any alerts from a particular instance, they have to copy/delete all of the provisioned alerts.

Instead, it would be nice to just be able to include some kind of configuration where admins could disable alerts for an instance.

@mrjones-plip
Copy link
Contributor

@eljhkrr - while you're in there redoing the alerts in 832 and 98, you likely can solve this ticket for free.

basically, a way to not alert on dev instances, but still have them in watchdog!

@eljhkrr eljhkrr self-assigned this Apr 12, 2024
@eljhkrr
Copy link
Member

eljhkrr commented Apr 29, 2024

Completed in #832

@eljhkrr eljhkrr closed this as completed Apr 29, 2024
@mrjones-plip
Copy link
Contributor

@eljhkrr - we'd love to expose a way for end users of Watchdog to know how to ignore specific CHT instances. Is there a config change at we can upstream your work into the default alerts in Watchdog? If not, is there some content we can add to the docs?

@eljhkrr
Copy link
Member

eljhkrr commented Apr 29, 2024

One of the ways of automatically ignoring specific CHT instances would be to introduce a condition on the expression such that instances with .dev for example are not alerted on. However, my take is that this decision should be made by a human making manual updates. In my experience dev instances have periods when a team would be interested in knowing if something isn't right e.g. during training. Reopening to add to documentation.

@eljhkrr eljhkrr reopened this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants