Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-validate designs before starting to write anything #15

Open
jkuester opened this issue Jan 23, 2024 · 0 comments
Open

Pre-validate designs before starting to write anything #15

jkuester opened this issue Jan 23, 2024 · 0 comments

Comments

@jkuester
Copy link
Collaborator

Currently we check that amount and getDoc exist in a design before writing any docs for that design. If the design is missing one of these values, it is skipped, but the rest of the designs from the file are still processed and the docs written. It seems like it might be better to not write anything if we detect that the design is bad.

We could pre-validate the whole design array before starting to write any of the docs. That way, we should never skip any docs once we start writing....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant