Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageIconUrl is deprecated in Meilisearch.csproj #379

Open
juchom opened this issue Dec 13, 2022 · 1 comment
Open

PackageIconUrl is deprecated in Meilisearch.csproj #379

juchom opened this issue Dec 13, 2022 · 1 comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)

Comments

@juchom
Copy link
Contributor

juchom commented Dec 13, 2022

When you build the project you have this warning :

C:\Program Files\dotnet\sdk\7.0.100\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(221,5): warning NU5048: The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIc
on'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl [C:\dev\meilisearch-dotnet\src\Meilisearch\Meilisearch.csproj]

There is nothing serious but you may want to update the csproj by adding the icon file in this repository and use the PacakgeIcon and drop PacakgeIconUrl

Microsoft documentation : https://learn.microsoft.com/en-us/nuget/reference/msbuild-targets#packageiconurl

I think you could ignore the backward compatibility tip and completly drop PacakgeIconUrl even Microsoft is not using it.

@brunoocasali brunoocasali added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Dec 13, 2022
@alallema
Copy link
Contributor

Thank you so much @juchom for raising this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

No branches or pull requests

3 participants