Skip to content

Latest commit

 

History

History
165 lines (113 loc) · 8.16 KB

CONTRIBUTING.md

File metadata and controls

165 lines (113 loc) · 8.16 KB
Raw

Contributing

First of all, thank you for contributing to Meilisearch! The goal of this document is to provide everything you need to know in order to contribute to Meilisearch and its different integrations.

Assumptions

  1. You're familiar with GitHub and the Pull Request(PR) workflow.
  2. You've read the Meilisearch documentation and the README.
  3. You know about the Meilisearch community. Please use this for help.

How to Contribute

  1. Make sure that the contribution you want to make is explained or detailed in a GitHub issue! Find an existing issue or open a new one.
  2. Once done, fork the meilisearch-rails repository in your own GitHub account. Ask a maintainer if you want your issue to be checked before making a PR.
  3. Create a new Git branch.
  4. Review the Development Workflow section that describes the steps to maintain the repository.
  5. Make the changes on your branch.
  6. Submit the branch as a PR pointing to the main branch of the main meilisearch-rails repository. A maintainer should comment and/or review your Pull Request within a few days. However depending on the circumstances, it may take longer.
    We do not enforce a naming convention for the PRs, but please use something descriptive of your changes, keeping in mind that the title of your PR will be automatically added to the next release changelog.

Development Workflow

Setup

You can set up your local environment natively or using docker, check out the docker-compose.yml.

Example of running all the checks with docker:

docker-compose run --rm package bash -c "bundle install && bundle exec rspec && bundle exec rubocop"

To install dependencies:

bundle install

Tests

Optionally, set the credentials of the Meilisearch instance as environment variables. The defaults are:

MEILISEARCH_HOST="http://127.0.0.1:7700"
MEILISEARCH_API_KEY="masterKey"

Each PR should pass the tests to be accepted.

# Tests
docker pull getmeili/meilisearch:latest # Fetch the latest version of Meilisearch image from Docker Hub
docker run -p 7700:7700 getmeili/meilisearch:latest meilisearch --master-key=masterKey --no-analytics
bundle exec rspec
# Launch a single test in a specific file
bundle exec rspec spec/integration_spec.rb -e 'should include _formatted object'
# Launch tests in a specific folder or file
bundle exec rspec spec/integration_spec.rb

Linter

Each PR should pass the linter to be accepted.

# Check the linter errors
bundle exec rubocop lib/ spec/
# Auto-correct the linter errors
bundle exec rubocop -a lib/ spec/

If you think the remaining linter errors are acceptable, do not add any rubocop in-line comments in the code.
This project uses a rubocop_todo.yml file that is generated. Do not modify this file manually.
To update it, run the following command:

bundle exec rubocop --auto-gen-config

Playground

Check the playground's README for more information.

Use docker to run the playground environment:

docker-compose up playground

It will use your local meilisearch-rails source code as the meilisearch-rails gem. And will get the same meilisearch instance running as the package service.

Troubleshoot:

If for some reason the app does not start open a playground console with docker-compose run --rm playground bash and run these administrative commands:

yarn install
bundle install
bundle exec rails db:setup

⚠️ Set your Meilisearch credentials by modifying the file playground/config/initializers/meilisearch.rb

Git Guidelines

Git Branches

All changes must be made in a branch and submitted as PR. We do not enforce any branch naming style, but please use something descriptive of your changes.

Git Commits

As minimal requirements, your commit message should:

  • be capitalized
  • not finish by a dot or any other punctuation character (!,?)
  • start with a verb so that we can read your commit message this way: "This commit will ...", where "..." is the commit message. e.g.: "Fix the home page button" or "Add more tests for create_index method"

We don't follow any other convention, but if you want to use one, we recommend this one.

GitHub Pull Requests

Some notes on GitHub PRs:

  • Convert your PR as a draft if your changes are a work in progress: no one will review it until you pass your PR as ready for review.
    The draft PR can be very useful if you want to show that you are working on something and make your work visible.
  • The branch related to the PR must be up-to-date with main before merging. Fortunately, this project integrates a bot to automatically enforce this requirement without the PR author having to do it manually.
  • All PRs must be reviewed and approved by at least one maintainer.
  • The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next release changelogs.

Release Process (for the internal team only)

Meilisearch tools follow the Semantic Versioning Convention.

Automation to Rebase and Merge the PRs

This project integrates a bot that helps us manage pull requests merging.
Read more about this.

Automated Changelogs

This project integrates a tool to create automated changelogs.
Read more about this.

How to Publish the Release

⚠️ Before doing anything, make sure you got through the guide about Releasing an Integration.

Make a PR modifying the file lib/meilisearch/version.rb with the right version.

VERSION = 'X.X.X'

Once the changes are merged on main, you can publish the current draft release via the GitHub interface: on this page, click on Edit (related to the draft release) > update the description (be sure you apply these recommendations) > when you are ready, click on Publish release.

A GitHub Action will be triggered and push the package to RubyGems.

Thank you again for reading this through. We can not wait to begin to work with you if you make your way through this contributing guide ❤️