-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0, drop unmaintained dependencies and release 2.0 #336
Comments
Version 2 could also drop the deprecated aliases: <service id="search.client" alias="meilisearch.client" public="true">
<deprecated package="meilisearch/search-bundle" version="0.14">The "%alias_id%" service alias is deprecated. Use "meilisearch.client" instead.</deprecated>
</service>
<service id="Meilisearch\Client" alias="meilisearch.client" public="true" />
<service id="search.client" alias="meilisearch.client" public="true">
<deprecated package="meilisearch/search-bundle" version="0.14">The "%alias_id%" service alias is deprecated. Use "meilisearch.client" instead.</deprecated>
</service> |
4.4 is not supported anymore |
What that would change for you? We need to support the Symfony supported versions otherwise it'd make this bundle less attractive |
Ah, I was using https://github.com/94noni/meilisearch-symfony/blob/main/composer.json for the debug toolbar, but that allows Symfony 4.4 It's okay to drop old dependencies, like PHP 7.4, but tag that as a release so that people stuck using those environments can still install and use the bundle. But they won't get all the latest features. Often that's a good reason to update! Like I suggested, support 5.4 and PHP 7 in Version 1, then bump to version 2. I like having typehints and such when using the library, that's the main thing it would change. To me, this bundle feels "dated" because it doesn't use PHP 8. But I don't use this bundle much, because I need to control the indexing more than setting a serialization group, and often don't even have an entity, as discussed in #302 . Anyway, the motivation for this is the debug toolbar! Once that's integrated, then I'd like to use this bundle more. Obviously, supporting PHP 7 isn't going to stop me from doing that, but I find PHP 8 so much better than my suggestion to drop it comes from improving the DX. I don't even have PHP 7 installed on my system. So if I were to contribute to this bundle (which I'd like to, I use the meilisearch-php library enough to have some ideas), as a developer I'd like to not be required to make sure any contributions also worked with PHP 7. That is, I think the development of this bundle is being held back by requiring that any contributions also work with an unmaintained version of PHP. |
There are still features that needs to be implemented before stable release, and also it's up to meilisearch team to decide when to release v1 :) But IIRC they decide this based on usage stats. And there is no reason to block people that stuck on older php versions to get updates because you don't like to contribute with older php versions 😉 |
By having the current release at 0.15, github treats it differently in version management, and it looks like it's still in beta. But this bundle works well enough to be released.
I think, though, that it's being unnecessarily held back by supporting PHP 7 and Symfony 4.4, both long past EOL. But since this version supports them, my idea is:
The text was updated successfully, but these errors were encountered: