-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implementation of createMany lifecycle hook #972
Open
Ra0R
wants to merge
10
commits into
meilisearch:main
Choose a base branch
from
Tacture:feat/create-many-lifecycle-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of creating a single update task for every document
… introduced in @strapi/strapi: 4.9.0
Ra0R
changed the title
Feat/create many lifecycle hook
Feature: Implementation of createMany lifecycle hook
Nov 4, 2024
@brunoocasali Looking forward to your review. |
@brunoocasali Any news on this? This would be an important change also for the company I am working at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
createMany
-Hook that is available sinceStrapi v4.9.0
, thecreateMany()
-Lifecycle hook properly returns a count and a set of ids after creation."peerDependencies": { "@strapi/strapi": "^4.9.0" }
Related issue
Fixes #965
Probably fixes #399 (I am not sure how tasks are updated upon restart)
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
Have you read the contributing guidelines?
However, I could not lint since there would be changes in 67 to remove carriage-returns(
error Delete
␍prettier/prettier
)Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!