Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implementation of createMany lifecycle hook #972

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Ra0R
Copy link

@Ra0R Ra0R commented Nov 4, 2024

Pull Request

  • Implemented createMany-Hook that is available sinceStrapi v4.9.0, the createMany()-Lifecycle hook properly returns a count and a set of ids after creation.
  • Test of the implemented function also extended mock to properly test behaviour
  • Bumped peerDependencies to "peerDependencies": { "@strapi/strapi": "^4.9.0" }

Related issue

Fixes #965
Probably fixes #399 (I am not sure how tasks are updated upon restart)

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?

  • Have you read the contributing guidelines?
    However, I could not lint since there would be changes in 67 to remove carriage-returns( error Delete prettier/prettier )

  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ra0R Ra0R changed the title Feat/create many lifecycle hook Feature: Implementation of createMany lifecycle hook Nov 4, 2024
@Ra0R Ra0R marked this pull request as draft November 4, 2024 15:01
@Ra0R
Copy link
Author

Ra0R commented Nov 4, 2024

@brunoocasali Looking forward to your review.

@Ra0R Ra0R marked this pull request as ready for review November 10, 2024 14:17
@dosomder
Copy link

@brunoocasali Any news on this? This would be an important change also for the company I am working at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hook into createMany lifecycle hook Add a debounce/throttle on document addition
2 participants