Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] The 'extern' directory is missing from comfy-mtb .zip from ComfyUI registry #230

Open
xbourque opened this issue Jan 7, 2025 · 2 comments
Assignees
Labels
status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working

Comments

@xbourque
Copy link

xbourque commented Jan 7, 2025

Describe the bug

When installing MTB nodes from the ComfyUI Manager, the 'extern' directory is missing from the .zip file downloaded from the ComfyUI Manager at https://storage.googleapis.com/comfy-registry/mel/comfy-mtb/0.4.0/node.zip

This makes MTB nodes fail to import when starting the ComfyUI server.

Reproduction

  1. Install MTB nodes from ComfyUI manager.
  2. Restart ComfyUI server
  3. MTB nodes fail to import with No such file or directory: '/mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb/extern'

Expected behavior

MTB nodes should import when installed from the ComfyUI Manager.

Operating System

Linux

Comfy Mode

In a custom virtual env (venv, virtualenv, conda...)

Console output

Traceback (most recent call last):
  File "/mnt/comfyui_volume/ComfyUI/nodes.py", line 2106, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb/__init__.py", line 36, in <module>
    from .endpoint import endlog
  File "/mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb/endpoint.py", line 6, in <module>
    from .utils import (
  File "/mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb/utils.py", line 476, in <module>
    for pth in extern_root.iterdir():
  File "/usr/lib64/python3.11/pathlib.py", line 931, in iterdir
    for name in os.listdir(self):
                ^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb/extern'

Cannot import /mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb module for custom nodes: [Errno 2] No such file or directory: '/mnt/comfyui_volume/ComfyUI/custom_nodes/comfy-mtb/extern'

Additional context

No response

@xbourque xbourque added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Jan 7, 2025
@melMass
Copy link
Owner

melMass commented Jan 7, 2025

Thanks for the report... that's unfortunate 0.4.0 is quite old it was a mistake release from the CI and has been marked as deprecated immediatly, I'll ask why the cli resolves to this version.

The latest version is 0.2.1 that addresses precisely this issue (#227)

image

@xbourque
Copy link
Author

xbourque commented Jan 7, 2025

Unfortunately, I don't see v0.2.1 in the Manager... I only get v0.1.5, v0.1.6 and v0.4.0 as choices when using the version picker from ComfyUI Manager.

image

'Nightly' works but the Manager defaults to 0.4.0 when installing multiple missing nodes at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants