Skip to content

Please add support to properly disable player 1 input by setting the unused index "16" #36

Open
@bengtj

Description

@bengtj

Hi,

I added a 360 wired controller to my picade. As the builtin joystick works as a keyboard by default they both controlled player 1.

Then I tried to map the joystick to player 2 using your script. Unfortunately this resulted in both player 1 and 2 being controlled the controller. The keyboard still controlling only player 1 though.

After some debugging I realized that unset player 1 meant commenting out this line:
# input_player1_joypad_index = "0"
Then I tried to change it to a non-existing controller like this and everything worked in mame:
input_player1_joypad_index = "16"

So I'm suggesting that you allow setting index "16" for player 1 as well, removing "[[ "$i" -ne 1 ]] && ":

    # do not give the option to disable input for player1
    [[ "$i" -ne 1 ]] && options+=" D \"Disable input for player$i\""

When you only allow unset it will not work for those with keyboard+joystick I think.

I suspect that you do not allow disabling player 1 joystick to not loose control completely? Or maybe it just felt like the sane thing to do?
A warning could be in place "Only disable player 1 joystick if using an alternative input device like a keyboard"? Or maybe do not allow to disable all joysticks or something like that?

Thank you for your joystick config script!

/Bengt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions