Allow disabling cache, some refinements to version selection #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregorio Litenstein <[email protected]>
Signed-off-by: Gregorio Litenstein <[email protected]>
It’s a useless test. Signed-off-by: Gregorio Litenstein <[email protected]>
Lord-Kamina
force-pushed
the
default-version
branch
from
5bf86f3 to
1e4b1f1
Compare
|
It looks great, thanks! I'll review that today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple things.
It adds an input to allow disabling the cache step. The reason for this is because I intend to wrap this action with something I'm working on, and I'll implement the caching in there.
It removes the "version" parameter from the CI workflows, which is related to
The action gets the version information exclusively from the parameter file. But, if that is left blank, it instead defaults to the latest macports release. If a version is specified, much like using a different prefix, macports will be built from source instead of using an installer package. The reason for this is simple: The package runs selfupdate as a postflight script. If somebody goes to the trouble of specifying a particular version, I assume it's because for some reason they don't want the latest version and thus presumably, they wouldn't want it to update automatically. (Don't really know why would someone want that, though)