From dcc8afc0eb39c16d4b222731198c43684817b257 Mon Sep 17 00:00:00 2001 From: GusGorman Date: Tue, 26 Dec 2023 21:40:08 -0600 Subject: [PATCH 01/12] Create honda_kr5vxx.c Added decoded for Honda car keyfob FCCID KR5V2X and 1X --- src/devices/honda_kr5vxx.c | 124 +++++++++++++++++++++++++++++++++++++ 1 file changed, 124 insertions(+) create mode 100644 src/devices/honda_kr5vxx.c diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c new file mode 100644 index 000000000..16dbdcd03 --- /dev/null +++ b/src/devices/honda_kr5vxx.c @@ -0,0 +1,124 @@ +/** @file + Honda Car Key FCCID KR5V2X and KR5V1X + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + +*/ + +/** + Decoder for Honda Car Keyfob + FCCID KR5V2X + Frequency 433.66 MHz and 434.18 MHz + + FCCID KR5V1X + Frequency 313.55 MHz and 314.15 MHz +*/ + + + +#include "decoder.h" + +static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ + + if( bitbuffer->bits_per_row[0] < 150 || bitbuffer->bits_per_row[0] > 184 ){ return DECODE_ABORT_EARLY; } //honda signals are usually 182 bits + + uint16_t bit_offset; + uint8_t const preamble[] = {0xEC, 0x0F, 0x62}; //honda keyfob manufacture code + bit_offset = bitbuffer_search(bitbuffer, 0, 0, preamble, sizeof(preamble) * 8); + if( bit_offset >= bitbuffer->bits_per_row[0] || + (bit_offset + 136) > bitbuffer->bits_per_row[0] ){ return DECODE_ABORT_EARLY; } + + + uint8_t hondacode[16]; + bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, hondacode, 120); //extract 120 bits starting at position ~45 + + char const *car_command = "Unknown"; + char const *command_half = "Unknown"; + int keyfob_id = ((unsigned)hondacode[2] << 24) | (hondacode[3] << 16) | (hondacode[4] << 8) | (hondacode[5]); + int keyfob_counter = (hondacode[7] << 16) | (hondacode[8] << 8) | (hondacode[9]); + int rolling_code = ((unsigned)hondacode[10] << 24) | (hondacode[11] << 16) | (hondacode[12] << 8) | (hondacode[13]); + + switch( hondacode[6] ){ + case 0x21: + car_command = "Lock(0x21)"; + break; + case 0x22: + car_command = "Unlock(0x22)"; + break; + case 0x24: + car_command = "Trunk(0x24)"; + break; + case 0x2d: + car_command = "RemoteStart(0x2D)"; + break; + case 0x27: + car_command = "Emergency(0x27)"; + break; + } + + switch( hondacode[1] ){ + case 0x08: + command_half = "1st(0x08)"; + break; + case 0x0a: + command_half = "2nd(0x0a)"; + break; + } + + char raw_code[34]; + char *ptr = &raw_code[0]; + + for(int i=0; i<15; i++){ + ptr += sprintf(ptr, "%02X", hondacode[i]); + } + + int crc_value = crc8(hondacode, 14, 0x2f, 0x00); //OPENSAFETY-CRC8 uses polynomial 0x2F and init 0x00 + if( crc_value != (hondacode[14])){ + decoder_log(decoder, 1, __func__, "CRC error"); + return DECODE_FAIL_MIC; + } + + data_t *data = data_make( + "model", "", DATA_STRING, "Honda Keyfob", + "raw_code", "RawCode", DATA_STRING, raw_code, + "keyfob_id", "KeyfobID", DATA_FORMAT, "%08x", DATA_INT, keyfob_id, + "car_command", "CarCommand", DATA_STRING, car_command, + "command_half", "CommandHalf", DATA_STRING, command_half, + "keyfob_counter","FobCounter", DATA_FORMAT, "%06x", DATA_INT, keyfob_counter, + "rolling_code", "RollCode", DATA_FORMAT, "%08x", DATA_INT, rolling_code, + "crc_value", "CRCvalue", DATA_FORMAT, "%02x", DATA_INT, crc_value, + "mic", "Integrity", DATA_STRING, "CRC", + NULL); + + decoder_output_data(decoder, data); + return 1; +} + + +static char const *const output_fields[] = { + "model", + "raw_code", + "keyfob_id", + "car_command", + "command_half", + "keyfob_counter", + "rolling_code", + "crc_value", + "mic", + NULL, +}; + + +r_device const honda_keyfob = { + .name = "Honda keyfob", + .modulation = FSK_PULSE_MANCHESTER_ZEROBIT, + .short_width = 60, + .long_width = 124, + .gap_limit = 1000, //this gap is kinda irrelevant + .reset_limit = 75000, + .decode_fn = &honda_decode, + .fields = output_fields, +}; From 5f03b5ad31e593d1d6b086296db7a4d26b2201c2 Mon Sep 17 00:00:00 2001 From: GusGorman Date: Tue, 26 Dec 2023 21:41:51 -0600 Subject: [PATCH 02/12] Update rtl_433_devices.h Added honda_keyfob device --- include/rtl_433_devices.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/rtl_433_devices.h b/include/rtl_433_devices.h index 3561c4d74..8af5b8356 100644 --- a/include/rtl_433_devices.h +++ b/include/rtl_433_devices.h @@ -259,6 +259,7 @@ DECL(bresser_lightning) \ DECL(schou_72543_rain) \ DECL(fineoffset_wh55) \ + DECL(honda_keyfob) \ /* Add new decoders here. */ From e306f79cac695ef770c1298802be9b60e1331596 Mon Sep 17 00:00:00 2001 From: GusGorman Date: Tue, 26 Dec 2023 21:43:57 -0600 Subject: [PATCH 03/12] Update CMakeLists.txt Added device honda_kr5vxx --- src/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 55c4469ab..5fcf700a9 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -134,6 +134,7 @@ add_library(r_433 STATIC devices/hideki.c devices/holman_ws5029.c devices/hondaremote.c + devices/honda_kr5vxx.c devices/honeywell.c devices/honeywell_cm921.c devices/honeywell_wdb.c From f994419a44f6e2e99ac92ca786c395ef7c281e56 Mon Sep 17 00:00:00 2001 From: GusGorman Date: Tue, 26 Dec 2023 21:56:10 -0600 Subject: [PATCH 04/12] Update honda_kr5vxx.c Added signal info to comments --- src/devices/honda_kr5vxx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index 16dbdcd03..ee84bca0b 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -15,6 +15,8 @@ FCCID KR5V1X Frequency 313.55 MHz and 314.15 MHz + + Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps */ From 07f945f70fd3a59c7a78bcddb3d3d18f846979b6 Mon Sep 17 00:00:00 2001 From: GusGorman Date: Wed, 27 Dec 2023 22:03:22 -0600 Subject: [PATCH 05/12] Update honda_kr5vxx.c Formatted code for simplified output and common variable names --- src/devices/honda_kr5vxx.c | 76 ++++++++++++++------------------------ 1 file changed, 28 insertions(+), 48 deletions(-) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index ee84bca0b..8133fe1ba 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -11,12 +11,12 @@ /** Decoder for Honda Car Keyfob FCCID KR5V2X - Frequency 433.66 MHz and 434.18 MHz + Frequency 433.66 MHz or 434.18 MHz FCCID KR5V1X - Frequency 313.55 MHz and 314.15 MHz + Frequency 313.55 MHz or 314.15 MHz - Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps + Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps */ @@ -25,6 +25,8 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ + if (bitbuffer->num_rows > 1){ return DECODE_ABORT_EARLY; } //should only be 1 row + if( bitbuffer->bits_per_row[0] < 150 || bitbuffer->bits_per_row[0] > 184 ){ return DECODE_ABORT_EARLY; } //honda signals are usually 182 bits uint16_t bit_offset; @@ -34,64 +36,45 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ (bit_offset + 136) > bitbuffer->bits_per_row[0] ){ return DECODE_ABORT_EARLY; } - uint8_t hondacode[16]; - bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, hondacode, 120); //extract 120 bits starting at position ~45 + uint8_t b[16]; + bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, b, 120); //extract 120 bits starting at position ~45, excluding first 2 bytes of manufacture code - char const *car_command = "Unknown"; - char const *command_half = "Unknown"; - int keyfob_id = ((unsigned)hondacode[2] << 24) | (hondacode[3] << 16) | (hondacode[4] << 8) | (hondacode[5]); - int keyfob_counter = (hondacode[7] << 16) | (hondacode[8] << 8) | (hondacode[9]); - int rolling_code = ((unsigned)hondacode[10] << 24) | (hondacode[11] << 16) | (hondacode[12] << 8) | (hondacode[13]); + char const *event = "Unknown"; + int device_id = ((unsigned)b[2] << 24) | (b[3] << 16) | (b[4] << 8) | (b[5]); + int device_counter = (b[7] << 16) | (b[8] << 8) | (b[9]); //keyfob counter hex value + int rolling_code = ((unsigned)b[10] << 24) | (b[11] << 16) | (b[12] << 8) | (b[13]); - switch( hondacode[6] ){ + switch( b[6] ){ case 0x21: - car_command = "Lock(0x21)"; + event = "Lock"; //value 0x21 break; case 0x22: - car_command = "Unlock(0x22)"; + event = "Unlock"; //value 0x22 break; case 0x24: - car_command = "Trunk(0x24)"; + event = "Trunk"; //value 0x24 break; case 0x2d: - car_command = "RemoteStart(0x2D)"; + event = "RemoteStart"; //value 0x2D break; case 0x27: - car_command = "Emergency(0x27)"; + event = "Emergency"; //value 0x27 break; } - switch( hondacode[1] ){ - case 0x08: - command_half = "1st(0x08)"; - break; - case 0x0a: - command_half = "2nd(0x0a)"; - break; - } - - char raw_code[34]; - char *ptr = &raw_code[0]; - - for(int i=0; i<15; i++){ - ptr += sprintf(ptr, "%02X", hondacode[i]); - } - int crc_value = crc8(hondacode, 14, 0x2f, 0x00); //OPENSAFETY-CRC8 uses polynomial 0x2F and init 0x00 - if( crc_value != (hondacode[14])){ + int crc_value = crc8(b, 14, 0x2f, 0x00); //OPENSAFETY-CRC8 uses polynomial 0x2F and init 0x00 + if( crc_value != (b[14])){ decoder_log(decoder, 1, __func__, "CRC error"); return DECODE_FAIL_MIC; } data_t *data = data_make( "model", "", DATA_STRING, "Honda Keyfob", - "raw_code", "RawCode", DATA_STRING, raw_code, - "keyfob_id", "KeyfobID", DATA_FORMAT, "%08x", DATA_INT, keyfob_id, - "car_command", "CarCommand", DATA_STRING, car_command, - "command_half", "CommandHalf", DATA_STRING, command_half, - "keyfob_counter","FobCounter", DATA_FORMAT, "%06x", DATA_INT, keyfob_counter, - "rolling_code", "RollCode", DATA_FORMAT, "%08x", DATA_INT, rolling_code, - "crc_value", "CRCvalue", DATA_FORMAT, "%02x", DATA_INT, crc_value, + "id", "Device ID", DATA_FORMAT, "%08x", DATA_INT, device_id, + "event", "Event", DATA_STRING, event, + "counter","Counter", DATA_FORMAT, "%06x", DATA_INT, device_counter, + "code", "Code", DATA_FORMAT, "%08x", DATA_INT, rolling_code, "mic", "Integrity", DATA_STRING, "CRC", NULL); @@ -102,20 +85,17 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ static char const *const output_fields[] = { "model", - "raw_code", - "keyfob_id", - "car_command", - "command_half", - "keyfob_counter", - "rolling_code", - "crc_value", + "id", + "event", + "counter", + "code", "mic", NULL, }; r_device const honda_keyfob = { - .name = "Honda keyfob", + .name = "Honda Keyfob", .modulation = FSK_PULSE_MANCHESTER_ZEROBIT, .short_width = 60, .long_width = 124, From 353c7fd0ff466a15595296093b71e83b7bcf245b Mon Sep 17 00:00:00 2001 From: GusGorman Date: Wed, 27 Dec 2023 22:35:49 -0600 Subject: [PATCH 06/12] Update honda_kr5vxx.c Added more decoder info to comments --- src/devices/honda_kr5vxx.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index 8133fe1ba..af20e7fc6 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -17,6 +17,21 @@ Frequency 313.55 MHz or 314.15 MHz Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps + Device uses Manchester encoded pulses of 60 us and 120 us + Data packet starts with sync of 0xFFFFFFFFFFF + Data layout after sync: + MMMMMM HH DDDDDDDD EE NNNNNN RRRRRRRR CC + + - M: 24 bit Manufacturer ID + - H: 8 bit indicator of packet number (keyfob button press sends packet 2 times, reciever requires both packets. 0x08 is first packet, 0x0a is second packet) + - D: 32 bit Device ID of keyfob + - E: 8 bit Keyfob command (event) + - N: 24 bit counter + - R: 32 bit Rolling Code + - C: 8 bit CRC, OPENSAFETY poly 0x2f init 0x00 + + Flex decoder: rtl_433 -f 433657000 -R 0 -X 'n=honda,m=FSK_MC_ZEROBIT,s=60,l=120,r=75000,preamble={32}0xffffec0f' + */ @@ -27,7 +42,7 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ if (bitbuffer->num_rows > 1){ return DECODE_ABORT_EARLY; } //should only be 1 row - if( bitbuffer->bits_per_row[0] < 150 || bitbuffer->bits_per_row[0] > 184 ){ return DECODE_ABORT_EARLY; } //honda signals are usually 182 bits + if( bitbuffer->bits_per_row[0] < 150 || bitbuffer->bits_per_row[0] > 184 ){ return DECODE_ABORT_EARLY; } uint16_t bit_offset; uint8_t const preamble[] = {0xEC, 0x0F, 0x62}; //honda keyfob manufacture code @@ -37,7 +52,7 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ uint8_t b[16]; - bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, b, 120); //extract 120 bits starting at position ~45, excluding first 2 bytes of manufacture code + bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, b, 120); //extract 120 bits, excluding first 2 bytes of manufacture code char const *event = "Unknown"; int device_id = ((unsigned)b[2] << 24) | (b[3] << 16) | (b[4] << 8) | (b[5]); @@ -98,7 +113,7 @@ r_device const honda_keyfob = { .name = "Honda Keyfob", .modulation = FSK_PULSE_MANCHESTER_ZEROBIT, .short_width = 60, - .long_width = 124, + .long_width = 120, .gap_limit = 1000, //this gap is kinda irrelevant .reset_limit = 75000, .decode_fn = &honda_decode, From b18e3dcb39e3c4b37b14e773f077494e0cd2e1bf Mon Sep 17 00:00:00 2001 From: GusGorman Date: Wed, 27 Dec 2023 22:48:17 -0600 Subject: [PATCH 07/12] Update honda_kr5vxx.c Fixed typos, removed redundant comments --- src/devices/honda_kr5vxx.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index af20e7fc6..15912a9c1 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -18,12 +18,13 @@ Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps Device uses Manchester encoded pulses of 60 us and 120 us + Data packets are usually 180 bits (full sync included) Data packet starts with sync of 0xFFFFFFFFFFF Data layout after sync: MMMMMM HH DDDDDDDD EE NNNNNN RRRRRRRR CC - M: 24 bit Manufacturer ID - - H: 8 bit indicator of packet number (keyfob button press sends packet 2 times, reciever requires both packets. 0x08 is first packet, 0x0a is second packet) + - H: 8 bit indicator of packet number (keyfob button press sends packet 2 times, receiver requires both packets. 0x08 is first packet, 0x0a is second packet) - D: 32 bit Device ID of keyfob - E: 8 bit Keyfob command (event) - N: 24 bit counter @@ -52,7 +53,7 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ uint8_t b[16]; - bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, b, 120); //extract 120 bits, excluding first 2 bytes of manufacture code + bitbuffer_extract_bytes( bitbuffer, 0, bit_offset + 16, b, 120); //extract 120 bits after sync, excluding first 2 bytes of manufacture code char const *event = "Unknown"; int device_id = ((unsigned)b[2] << 24) | (b[3] << 16) | (b[4] << 8) | (b[5]); @@ -61,24 +62,24 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ switch( b[6] ){ case 0x21: - event = "Lock"; //value 0x21 + event = "Lock"; break; case 0x22: - event = "Unlock"; //value 0x22 + event = "Unlock"; break; case 0x24: - event = "Trunk"; //value 0x24 + event = "Trunk"; break; case 0x2d: - event = "RemoteStart"; //value 0x2D + event = "RemoteStart"; break; case 0x27: - event = "Emergency"; //value 0x27 + event = "Emergency"; break; } - int crc_value = crc8(b, 14, 0x2f, 0x00); //OPENSAFETY-CRC8 uses polynomial 0x2F and init 0x00 + int crc_value = crc8(b, 14, 0x2f, 0x00); //OPENSAFETY-CRC8 if( crc_value != (b[14])){ decoder_log(decoder, 1, __func__, "CRC error"); return DECODE_FAIL_MIC; From c17bea07ef5b3f78e170d135566eb6fbfcd05f2c Mon Sep 17 00:00:00 2001 From: waffles Date: Sat, 30 Dec 2023 22:08:19 -0600 Subject: [PATCH 08/12] Fixed errors --- src/devices/honda_kr5vxx.c | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index 15912a9c1..384e2ff66 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -9,18 +9,18 @@ */ /** - Decoder for Honda Car Keyfob - FCCID KR5V2X - Frequency 433.66 MHz or 434.18 MHz - - FCCID KR5V1X - Frequency 313.55 MHz or 314.15 MHz - - Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps - Device uses Manchester encoded pulses of 60 us and 120 us - Data packets are usually 180 bits (full sync included) - Data packet starts with sync of 0xFFFFFFFFFFF - Data layout after sync: + Decoder for Honda Car Keyfob + FCCID KR5V2X + Frequency 433.66 MHz or 434.18 MHz + + FCCID KR5V1X + Frequency 313.55 MHz or 314.15 MHz + + Signal is 2FSK, 15 kHz deviation, datarate(baud) 16.66 kbps + Device uses Manchester encoded pulses of 60 us and 120 us + Data packets are usually 180 bits (with entire sync) + Data packet starts with sync of 0xFFFFFFFFFFF + Data layout after sync: MMMMMM HH DDDDDDDD EE NNNNNN RRRRRRRR CC - M: 24 bit Manufacturer ID @@ -32,7 +32,6 @@ - C: 8 bit CRC, OPENSAFETY poly 0x2f init 0x00 Flex decoder: rtl_433 -f 433657000 -R 0 -X 'n=honda,m=FSK_MC_ZEROBIT,s=60,l=120,r=75000,preamble={32}0xffffec0f' - */ @@ -40,7 +39,6 @@ #include "decoder.h" static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ - if (bitbuffer->num_rows > 1){ return DECODE_ABORT_EARLY; } //should only be 1 row if( bitbuffer->bits_per_row[0] < 150 || bitbuffer->bits_per_row[0] > 184 ){ return DECODE_ABORT_EARLY; } @@ -86,7 +84,7 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ } data_t *data = data_make( - "model", "", DATA_STRING, "Honda Keyfob", + "model", "model", DATA_STRING, "Honda Keyfob", "id", "Device ID", DATA_FORMAT, "%08x", DATA_INT, device_id, "event", "Event", DATA_STRING, event, "counter","Counter", DATA_FORMAT, "%06x", DATA_INT, device_counter, From 4817e6d61d7c837c45a84655f657bd5c39e3aa6b Mon Sep 17 00:00:00 2001 From: waffles Date: Sat, 30 Dec 2023 22:24:31 -0600 Subject: [PATCH 09/12] fixing errors --- src/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 5fcf700a9..85d0acc7f 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -133,8 +133,8 @@ add_library(r_433 STATIC devices/hcs200.c devices/hideki.c devices/holman_ws5029.c - devices/hondaremote.c devices/honda_kr5vxx.c + devices/hondaremote.c devices/honeywell.c devices/honeywell_cm921.c devices/honeywell_wdb.c From 1025fb85a19bbaccf51f7157c3c4120183195ac2 Mon Sep 17 00:00:00 2001 From: waffles Date: Sat, 30 Dec 2023 22:33:54 -0600 Subject: [PATCH 10/12] added fccid to model --- src/devices/honda_kr5vxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index 384e2ff66..1042ec29e 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -84,7 +84,7 @@ static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ } data_t *data = data_make( - "model", "model", DATA_STRING, "Honda Keyfob", + "model", "model", DATA_STRING, "Honda Keyfob KR5V2X/1X", "id", "Device ID", DATA_FORMAT, "%08x", DATA_INT, device_id, "event", "Event", DATA_STRING, event, "counter","Counter", DATA_FORMAT, "%06x", DATA_INT, device_counter, @@ -109,7 +109,7 @@ static char const *const output_fields[] = { r_device const honda_keyfob = { - .name = "Honda Keyfob", + .name = "Honda Keyfob KR5V2X/1X", .modulation = FSK_PULSE_MANCHESTER_ZEROBIT, .short_width = 60, .long_width = 120, From f5342c6bd8acfd9f066c388ecc31deebace0d539 Mon Sep 17 00:00:00 2001 From: gusgorman402 Date: Sat, 30 Dec 2023 22:39:08 -0600 Subject: [PATCH 11/12] ran maintainer.py --- README.md | 3 ++- conf/rtl_433.example.conf | 1 + man/man1/rtl_433.1 | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 525315e5f..5cd6056d2 100644 --- a/README.md +++ b/README.md @@ -337,6 +337,7 @@ See [CONTRIBUTING.md](./docs/CONTRIBUTING.md). [249] Bresser lightning [250] Schou 72543 Day Rain Gauge, Motonet MTX Rain, MarQuant Rain Gauge [251] Fine Offset / Ecowitt WH55 water leak sensor + [252] Honda Keyfob KR5V2X/1X * Disabled by default, use -R n or a conf file to enable @@ -346,7 +347,7 @@ See [CONTRIBUTING.md](./docs/CONTRIBUTING.md). [-d ] (default: 0) [-d :] To set gain for RTL-SDR use -g to set an overall gain in dB. - SoapySDR device driver is available. + SoapySDR device driver is not available. [-d ""] Open default SoapySDR device [-d driver=rtlsdr] Open e.g. specific SoapySDR device To set gain for SoapySDR use -g ELEM=val,ELEM=val,... e.g. -g LNA=20,TIA=8,PGA=2 (for LimeSDR). diff --git a/conf/rtl_433.example.conf b/conf/rtl_433.example.conf index 4e203b6fb..168c2d70f 100644 --- a/conf/rtl_433.example.conf +++ b/conf/rtl_433.example.conf @@ -478,6 +478,7 @@ convert si protocol 249 # Bresser lightning protocol 250 # Schou 72543 Day Rain Gauge, Motonet MTX Rain, MarQuant Rain Gauge protocol 251 # Fine Offset / Ecowitt WH55 water leak sensor + protocol 252 # Honda Keyfob KR5V2X/1X ## Flex devices (command line option "-X") diff --git a/man/man1/rtl_433.1 b/man/man1/rtl_433.1 index 2636143a8..ddf53eaeb 100644 --- a/man/man1/rtl_433.1 +++ b/man/man1/rtl_433.1 @@ -168,7 +168,7 @@ RTL\-SDR device driver is available. To set gain for RTL\-SDR use \-g to set an overall gain in dB. .RE .RS -SoapySDR device driver is available. +SoapySDR device driver is not available. .RE .TP [ \fB\-d\fI ""\fP ] From 51c6a4336b7dee945989d3d5797b3a359762fe3a Mon Sep 17 00:00:00 2001 From: gusgorman402 Date: Sat, 30 Dec 2023 22:44:45 -0600 Subject: [PATCH 12/12] Fixed newline error --- src/devices/honda_kr5vxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/devices/honda_kr5vxx.c b/src/devices/honda_kr5vxx.c index 1042ec29e..eb3e40a34 100644 --- a/src/devices/honda_kr5vxx.c +++ b/src/devices/honda_kr5vxx.c @@ -39,7 +39,7 @@ #include "decoder.h" static int honda_decode(r_device *decoder, bitbuffer_t *bitbuffer){ - if (bitbuffer->num_rows > 1){ return DECODE_ABORT_EARLY; } //should only be 1 row + if (bitbuffer->num_rows > 1){ return DECODE_ABORT_EARLY; } //should only be 1 row if( bitbuffer->bits_per_row[0] < 150 || bitbuffer->bits_per_row[0] > 184 ){ return DECODE_ABORT_EARLY; }