Skip to content

Commit 351a179

Browse files
committed
need a way to trigger log4j bug
1 parent adf2839 commit 351a179

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/main/java/org/apache/struts2/showcase/dao/LoginDao.java

+8-9
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,18 @@ public Class getFeaturedClass() {
2222
return User.class;
2323
}
2424

25-
public User getByUsernameAndPassword(String user, String pass)
26-
{
25+
public User getByUsernameAndPassword(String user, String pass) {
26+
User result = null;
2727
User inStorageUser = (User) get(user);
28-
29-
if(inStorageUser != null) {
28+
if (inStorageUser != null) {
3029
if (pass.equals(inStorageUser.getPassword())) {
31-
return inStorageUser;
32-
} else {
33-
return null;
30+
result = inStorageUser;
3431
}
35-
} else {
36-
return null;
3732
}
33+
if (result == null) {
34+
log.warn("Failed login " + user);
35+
}
36+
return result;
3837
}
3938

4039
public void addUser(User user) {

0 commit comments

Comments
 (0)