[Bug]: Clients / apps should auto-favorite nodes upon direct-message except for CLIENT_BASE nodes #932
Description
Before submitting
- I have searched existing issues to make sure this bug hasn't already been reported
- I have updated to the latest version of the software to verify the issue still exists
- I have cleared cache/cookies/storage or tried in a private/incognito window (if applicable)
Hardware
Not Applicable
Connection Type
HTTP
Local or Hosted
Firmware Version
2.7.X
Operating System
N/A
Browser
No response
Expected Behavior
Clients / apps should auto-favorite nodes upon direct-message except for CLIENT_BASE nodes
Actual Behavior
Currently I believe we have implemented automatic flavoriting upon DMing another node in all app platforms. This is generally considered desirable behavior as it ensures that the public keys are retained in the nodedb of the device. However, we have one context where this is extremely problematic, which is in the CLIENT_BASE role. In this role, we would be unintentionally creating routing issues for nodes which are not explicitly favorited by the user for relay out of their home base nodes.
Steps to Reproduce
N/A
Relevant console output
Screenshots
No response
Additional Context
No response