working for sp/mp, save last fov in configfile in appdata, change fov with +/-

Author: Matt

MW3FovChanger/MW3FovChanger.vcxproj.filters

@@ -14,15 +14,15 @@
     </Filter>
   </ItemGroup>
   <ItemGroup>
-    <ClCompile Include="src\main.cpp">
-      <Filter>main</Filter>
-    </ClCompile>
     <ClCompile Include="src\processhook.cpp">
       <Filter>process/mem</Filter>
     </ClCompile>
     <ClCompile Include="src\fovchanger.cpp">
       <Filter>fovchanger</Filter>
     </ClCompile>
+    <ClCompile Include="src\main.cpp">
+      <Filter>main</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="src\processhook.h">

MW3FovChanger/src/fovchanger.cpp

@@ -4,11 +4,39 @@
 #include <ShlObj.h>
 #include <Shlwapi.h>
 #include <string>
-#include <sstream>
 
 fov::Changer::Changer(float fov)
 	:fov(fov)
 {
+	CHAR szPath[MAX_PATH];
+
+	if (SUCCEEDED(SHGetFolderPathA(NULL, CSIDL_APPDATA, NULL, 0, szPath))) {
+
+		strcat_s(szPath, "\\mw3fovchanger\\config.cfg");
+
+		OFSTRUCT reopenbuff;
+		HFILE hfile = OpenFile(szPath, &reopenbuff, OF_READ);
+
+		if (hfile != HFILE_ERROR) {
+
+			char buf[64];
+			DWORD bytesread;
+			if (ReadFile((HANDLE)hfile, buf, 64, &bytesread, NULL)) {
+
+				buf[bytesread] = '\0';
+				float configFov = std::strtof(buf, nullptr);
+
+				this->fov = configFov;
+			}
+
+			CloseHandle((HANDLE)hfile);
+		}
+	}
+}
+
+fov::Changer::~Changer()
+{
+	fov::updateConfig(fov);
 }
 
 void fov::Changer::setfov_sp(const HANDLE hProc) const
@@ -43,23 +71,21 @@ void fov::Changer::setfov_mp(const HANDLE hProc) const
 	while (WriteProcessMemory(hProc, (LPVOID)fovmemaddress, &fov, sizeof(float), NULL)) Sleep(100);
 }
 
-fov::SettingsManager::SettingsManager(Changer * const pchanger)
-{
-}
-
-void fov::SettingsManager::safeDefaultFov(float newfov)
+void fov::updateConfig(float fov)
 {
 	TCHAR szPath[MAX_PATH];
 
 	if (SUCCEEDED(SHGetFolderPath(NULL, CSIDL_APPDATA, NULL, 0, szPath))) {
 
-		wcscat_s(szPath, L"\\mw3fovchanger\\config.cfg");
+		wcscat_s(szPath, L"\\mw3fovchanger");
+		CreateDirectory(szPath, NULL);
+
+		wcscat_s(szPath, L"\\config.cfg");
 		HANDLE hFile = CreateFile(szPath, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
 
-		std::stringstream ss;
-		ss << newfov;
+		if (hFile == INVALID_HANDLE_VALUE) return;
 
-		std::string s = ss.str();
+		std::string s = std::to_string(fov);
 
 		WriteFile(hFile, s.c_str(), s.length(), NULL, NULL);
 

MW3FovChanger/src/fovchanger.h

@@ -6,11 +6,9 @@ namespace fov {
 
 	class Changer {
 
-		friend class SettingsManager;
-
 	public:
 		Changer(float fov = 90.f);
-		virtual ~Changer() = default;
+		virtual ~Changer();
 
 		/*fov changing functions for singleplayer, this method blocks execution*/
 		void setfov_sp(const HANDLE hProc) const;
@@ -32,15 +30,6 @@ namespace fov {
 		float fov;
 	};
 
-	class SettingsManager {
-
-	public:
-
-		SettingsManager(Changer* const pchanger);
-		virtual ~SettingsManager() = default;
-
-		void safeDefaultFov(float newfov);
-	};
-
+	void updateConfig(float fov);
 }
 

MW3FovChanger/src/main.cpp

@@ -2,111 +2,87 @@
 #include <iostream>
 #include "processhook.h"
 #include "FovChanger.h"
-#include <thread>
+#include <future>
+#include <memory>
 
 #define VK_KEY_1 0x31
 
-/*this method blocks execution*/
-void userInputForFovChanger(fov::Changer* const pchanger);
-
 int main(int argc, char** argv) {
 
-	fov::Changer fovchanger;
-
-	std::thread uithread(userInputForFovChanger, &fovchanger);
-
-	/*Connect to process*/
-	DWORD pid = 0;
-	HANDLE hProc = NULL;
-
-	/*Connect to either, MP or SP*/
-	while (!pid) {
+	std::cout << "MW3 Fov Changer (Developed with love by Mesinger)" << std::endl;
+	std::cout << "[+[NUMPAD]] Increase FOV by 5" << std::endl;
+	std::cout << "[-[NUMPAD]] Decrease FOV by 5" << std::endl << std::endl;
 
-		//Singleplayer
-		pid = processhook::GetProcessId("Call of Duty®: Modern Warfare® 3");
-		if (pid) {
+	std::cout << "Please start MW3..." << std::endl;
 
-			hProc = OpenProcess(PROCESS_ALL_ACCESS, 0, pid);
+	while (true) {
 
-			if (hProc) {
+		fov::Changer fovchanger;
 
-				std::cout << "Attached to MW3" << std::endl;
+		/*Connect to process*/
+		DWORD pid = 0;
+		HANDLE hProc = NULL;
 
-				MessageBeep(MB_OKCANCEL);
-				fovchanger.setfov_sp(hProc);
-			}
+		std::unique_ptr<std::future<void>> worker;
 
-			break;
-		}
+		/*Connect to either, MP or SP*/
+		while (!pid) {
 
-		//Multiplayer
-		pid = processhook::GetProcessId("Call of Duty®: Modern Warfare® 3 Multiplayer");
-		if (pid) {
+			//Singleplayer
+			pid = processhook::GetProcessId("Call of Duty®: Modern Warfare® 3");
+			if (pid) {
 
-			hProc = OpenProcess(PROCESS_ALL_ACCESS, 0, pid);
+				hProc = OpenProcess(PROCESS_ALL_ACCESS, 0, pid);
 
-			if (hProc) {
+				if (hProc) {
 
-				std::cout << "Attached to MW3" << std::endl;
+					std::cout << "Attached to MW3" << std::endl;
 
-				MessageBeep(MB_OKCANCEL);
-				fovchanger.setfov_mp(hProc);
+					MessageBeep(MB_OKCANCEL);
+					worker = std::make_unique<std::future<void>>(std::async(&fov::Changer::setfov_sp, &fovchanger, hProc));
+					break;
+				}
 			}
 
-			break;
-		}
-
-		Sleep(100);
-	}
-
-	CloseHandle(hProc);
-	uithread.join();
-
-	MessageBeep(MB_OKCANCEL);
+			//Multiplayer
+			pid = processhook::GetProcessId("Call of Duty®: Modern Warfare® 3 Multiplayer");
+			if (pid) {
 
-	return EXIT_SUCCESS;
-}
+				hProc = OpenProcess(PROCESS_ALL_ACCESS, 0, pid);
 
-void userInputForFovChanger(fov::Changer* const pchanger)
-{
-	std::cout << "MW3 Fov Changer (Developed with love by Mesinger)" << std::endl;
-	std::cout << "[1] Set default FOV" << std::endl;
-	std::cout << "[+] Increase FOV by 5" << std::endl;
-	std::cout << "[-] Decrease FOV by 5" << std::endl << std::endl;
+				if (hProc) {
 
-	std::cout << "Please start MW3..." << std::endl;
+					std::cout << "Attached to MW3" << std::endl;
 
-	fov::SettingsManager fovmgr(pchanger);
-
-	while (true) {
+					MessageBeep(MB_OKCANCEL);
+					worker = std::make_unique<std::future<void>>(std::async(&fov::Changer::setfov_mp, &fovchanger, hProc));
+					break;
+				}
+			}
 
-		if (GetAsyncKeyState(VK_KEY_1)) {
+			Sleep(100);
+		}
 
-			std::cout << "Enter new fov[0 - 180]: ";
+		while (worker->wait_for(std::chrono::milliseconds(25)) != std::future_status::ready) {
 
-			float fov;
-			std::cin >> fov;
+			if (GetAsyncKeyState(VK_ADD)) {
 
-			if (!std::cin.fail()) {
-				std::cout << std::endl << "Invalid input" << std::endl;
-				continue;
+				float oldfov = fovchanger.getFov();
+				fovchanger.changeFov(oldfov + 5.f);
+				Sleep(125);
 			}
-			
-			if (pchanger->changeFov(fov)) {
-				fovmgr.safeDefaultFov(fov);
+			else if (GetAsyncKeyState(VK_SUBTRACT)) {
+
+				float oldfov = fovchanger.getFov();
+				fovchanger.changeFov(oldfov - 5.f);
+				Sleep(125);
 			}
 		}
-		else if (GetAsyncKeyState(VK_ADD)) {
 
-			float oldfov = pchanger->getFov();
-			pchanger->changeFov(oldfov + 5.f);
-		}
-		else if (GetAsyncKeyState(VK_SUBTRACT)) {
+		CloseHandle(hProc);
 
-			float oldfov = pchanger->getFov();
-			pchanger->changeFov(oldfov - 5.f);
-		}
-
-		Sleep(100);
+		std::cout << "Detached from MW3" << std::endl;
 	}
+
+	return EXIT_SUCCESS;
 }