how to address changes to Cargo subprojects in my repository?

[ognevny]

my repo was configured to work with Cargo subprojects so Cargo is not invoked for a build. it worked with meson 1.5, but one day it became broken :(

Executing subproject rusted method cargo

meson.build:29: WARNING: Cargo subproject is an experimental feature and has no backwards compatibility guarantees.

meson.build:29:4: ERROR: Neither a subproject directory nor a rusted-0.1-rs.wrap file was found.

I acknowledge that the whole Cargo thing is experimental, but I have no idea how to easily fix my code

[eli-schwartz]

I am not sure because you haven't shown the example project. But I found a "my-code" repository in your GitHub account with a meson subproject rusted.wrap and rusted/ which is directly invoked via subproject(). It is not named "correctly" to be usable as a dependency(), but in theory that shouldn't matter... Yet "executing subproject rusted".

It superficially looks like the cargo subproject handling attempts to load the project itself as a dependency... of itself. That smells like a bug.

Maybe @bonzini or @xclaesse can answer more.

[ognevny]

I am not sure because you haven't shown the example project.

the link I put was broken, fixed

It superficially looks like the cargo subproject handling attempts to load the project itself as a dependency... of itself. That smells like a bug.

the main point that it worked before. I'll probably check meson changes later for better understanding...

[bonzini]

patch never worked. My suggestion is that you don't use cargo subprojects at all for the time being, and probably at least not until 1.11 or so.

[ognevny]

fine. is there any good example on how to make a proper Cargo subproject in my case? (the goal is still the same: compile crate with external dependencies without invoking Cargo)

[ognevny]

tried with latest git commit and got this

Executing subproject rusted method cargo

meson.build:29: WARNING: Cargo subproject is an experimental feature and has no backwards compatibility guarantees.
rusted| WARNING: Cargo.toml package rusted has unexpected keys "patch". This may (unlikely) be an error in the cargo manifest, or may be a missing implementation in Meson. If this issue can be reproduced with the latest version of Meson, please help us by opening an issue at https://github.com/mesonbuild/meson/issues. Please include the crate and version that is generating this warning if possible.

meson.build:29:4: ERROR: Neither a subproject directory nor a rusted-0.1-rs.wrap file was found.

I remembered that [patch] worked with 1.5.0 too

[xclaesse]

Unknown fields were simply silently ignored, it now warns. But it never worked. The dependency provided by a cargo subproject is named rusted-0.1-rs, that naming changed. Either rename you .wrap with that name, or add that name in [provide] section of the wrap, with dependency_names=rusted-0.1-rs

[ognevny]

renaming and provide section didn't help, because dependencies from Cargo.lock weren't load

[ognevny]

after rename creating meson.build file is required. but anyway cargo dependencies and any meta info seem to not load. I believe that the point of previous changes was to prevent creating dozens of *.wrap files. but it seems the only solution here...

[ognevny]

If someone reach this, I finally manage to make it work with meson 1.9.1 on my repo: https://github.com/ognevny/my-code/tree/9f54f844968d52f58eb05e57fdfb0ea6872fc738. here is a test repo where I did so for a single project with no subdirs: https://github.com/ognevny/my-code-rusted