Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: highlights kubecost v2 breaking change #3134

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Feb 11, 2025

What problem does this PR solve?:
currently kubecost metadata overview doesn't include kubecost v2 breaking change

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105479

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cwyl02 cwyl02 added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Feb 11, 2025
@cwyl02 cwyl02 requested review from takirala, msdolbey and a team February 11, 2025 19:20
@cwyl02 cwyl02 self-assigned this Feb 11, 2025
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/kubecost labels Feb 11, 2025
@mesosphere-ci mesosphere-ci added do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Feb 11, 2025
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/ychen/kubecostv2-doc-string

@cwyl02 cwyl02 requested a review from cneth February 11, 2025 19:24
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
straight forward

@takirala takirala merged commit e6f56e3 into main Feb 12, 2025
22 checks passed
@takirala takirala deleted the ychen/kubecostv2-doc-string branch February 12, 2025 16:41
@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13273837295

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13268164056: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/kubecost size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants