Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(harbor): add manual bucket config #3140

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

mhrabovcin
Copy link
Contributor

What problem does this PR solve?:
Adds support for harbor manual bucket configuration.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-105674

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mhrabovcin mhrabovcin self-assigned this Feb 12, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. services/harbor labels Feb 12, 2025
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off update-licenses signals mergebot to update licenses.d2iq.yaml labels Feb 12, 2025
@jimmidyson jimmidyson merged commit ce2ca96 into main Feb 12, 2025
53 of 54 checks passed
@jimmidyson jimmidyson deleted the mh/harbor-manual-bucket branch February 12, 2025 14:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13287276126

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 13285242724: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off services/harbor size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants