Skip to content

Metadatabox cleanup #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
May 19, 2024
Merged

Metadatabox cleanup #2476

merged 29 commits into from
May 19, 2024

Conversation

@zas
Copy link
Collaborator

@zas zas commented May 17, 2024 •
edited
Loading

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested a review from phw May 17, 2024 13:03
@zas zas force-pushed the metadatabox_cleanup branch from 9395cdb to a78fcdc Compare May 17, 2024 13:44
@zas zas force-pushed the metadatabox_cleanup branch from bfe1a0c to d2f6227 Compare May 17, 2024 14:21
@zas zas force-pushed the metadatabox_cleanup branch from fdd893c to 791b8b2 Compare May 17, 2024 14:31
@zas
Drop _lookup_tags() in favor of new _lookup_tag(tag)
94ff51e 
- define methods to use as strings and use getattr()
@zas zas force-pushed the metadatabox_cleanup branch from 791b8b2 to 94ff51e Compare May 17, 2024 14:44
@zas
Copy link
Collaborator Author

zas commented May 17, 2024 •
edited
Loading

28d2b17 is a new feature, it will go in another PR if reviews are positive, just a PoC.

EDIT: move to #2478 (based on this branch though)

@zas zas force-pushed the metadatabox_cleanup branch from 28d2b17 to 72c7c60 Compare May 18, 2024 09:07
@zas zas marked this pull request as ready for review May 18, 2024 09:20
phw
phw approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is working great. Having this merged will also simplify reviewing #2478 (once rebased)

@zas zas merged commit 38304af into metabrainz:master May 19, 2024
@zas zas deleted the metadatabox_cleanup branch May 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phw phw phw approved these changes

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zas @phw