-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only Add Holidays For The Semester #129
Comments
Hello Maintainers, I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements: Summary of Changes: Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters. Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences. |
Hi @P-Potdar, We appreciate your response, but I am yet to see a PR. I hope you are working on it, and we will see it soon. |
yes i working on it |
The generated ics file includes institute holidays for the whole year. Due to this, some holidays may be repeated if gyft is used for both semesters. Adding holidays only relevant to the semester will be better.
Additionally, having an option to add holiday events or not would be nice.
The text was updated successfully, but these errors were encountered: