Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Add Holidays For The Semester #129

Open
harshkhandeparkar opened this issue Jan 4, 2024 · 3 comments
Open

Only Add Holidays For The Semester #129

harshkhandeparkar opened this issue Jan 4, 2024 · 3 comments

Comments

@harshkhandeparkar
Copy link
Member

The generated ics file includes institute holidays for the whole year. Due to this, some holidays may be repeated if gyft is used for both semesters. Adding holidays only relevant to the semester will be better.

Additionally, having an option to add holiday events or not would be nice.

@P-Potdar
Copy link

P-Potdar commented Oct 1, 2024

Hello Maintainers,

I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements:

Summary of Changes:
Semester-Specific Holidays:

Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters.
Optional Holiday Events:

Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences.
Benefits:
Improved User Experience: Reducing clutter in the calendar by avoiding repeated holidays makes it cleaner and easier to manage.
Flexibility: Users can customize their ICS file to better fit their needs, enhancing overall usability.
I believe these changes will significantly enhance the user experience, and I’m looking forward to your feedback. Thank you for considering this PR for Hacktoberfest 2024!

@proffapt
Copy link
Member

proffapt commented Oct 1, 2024

Hello Maintainers,

I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements:

Summary of Changes: Semester-Specific Holidays:

Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters. Optional Holiday Events:

Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences. Benefits: Improved User Experience: Reducing clutter in the calendar by avoiding repeated holidays makes it cleaner and easier to manage. Flexibility: Users can customize their ICS file to better fit their needs, enhancing overall usability. I believe these changes will significantly enhance the user experience, and I’m looking forward to your feedback. Thank you for considering this PR for Hacktoberfest 2024!

Hi @P-Potdar,

We appreciate your response, but I am yet to see a PR. I hope you are working on it, and we will see it soon.

@P-Potdar
Copy link

P-Potdar commented Oct 2, 2024

Hello Maintainers,
I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements:
Summary of Changes: Semester-Specific Holidays:
Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters. Optional Holiday Events:
Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences. Benefits: Improved User Experience: Reducing clutter in the calendar by avoiding repeated holidays makes it cleaner and easier to manage. Flexibility: Users can customize their ICS file to better fit their needs, enhancing overall usability. I believe these changes will significantly enhance the user experience, and I’m looking forward to your feedback. Thank you for considering this PR for Hacktoberfest 2024!

Hi @P-Potdar,

We appreciate your response, but I am yet to see a PR. I hope you are working on it, and we will see it soon.

yes i working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants