Only Add Holidays For The Semester

[harshkhandeparkar]

The generated ics file includes institute holidays for the whole year. Due to this, some holidays may be repeated if gyft is used for both semesters. Adding holidays only relevant to the semester will be better.

Additionally, having an option to add holiday events or not would be nice.

[P-Potdar]

Hello Maintainers,

I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements:

Summary of Changes:
Semester-Specific Holidays:

Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters.
Optional Holiday Events:

Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences.
Benefits:
Improved User Experience: Reducing clutter in the calendar by avoiding repeated holidays makes it cleaner and easier to manage.
Flexibility: Users can customize their ICS file to better fit their needs, enhancing overall usability.
I believe these changes will significantly enhance the user experience, and I’m looking forward to your feedback. Thank you for considering this PR for Hacktoberfest 2024!

[proffapt]

Hello Maintainers,

I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements:

Summary of Changes: Semester-Specific Holidays:

Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters. Optional Holiday Events:

Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences. Benefits: Improved User Experience: Reducing clutter in the calendar by avoiding repeated holidays makes it cleaner and easier to manage. Flexibility: Users can customize their ICS file to better fit their needs, enhancing overall usability. I believe these changes will significantly enhance the user experience, and I’m looking forward to your feedback. Thank you for considering this PR for Hacktoberfest 2024!

Hi @P-Potdar,

We appreciate your response, but I am yet to see a PR. I hope you are working on it, and we will see it soon.

[P-Potdar]

Hello Maintainers,
I’m excited to contribute to this project as part of Hacktoberfest 2024! 🎉 This PR aims to improve the ICS file generation by focusing on the following enhancements:
Summary of Changes: Semester-Specific Holidays:
Modified the ICS file generation to include only the holidays relevant to the current semester, preventing the issue of repeated holidays when using gyft for both semesters. Optional Holiday Events:
Introduced a feature that allows users to toggle the inclusion of holiday events in the generated ICS file. Users can now choose whether they want holidays to be included based on their preferences. Benefits: Improved User Experience: Reducing clutter in the calendar by avoiding repeated holidays makes it cleaner and easier to manage. Flexibility: Users can customize their ICS file to better fit their needs, enhancing overall usability. I believe these changes will significantly enhance the user experience, and I’m looking forward to your feedback. Thank you for considering this PR for Hacktoberfest 2024!

Hi @P-Potdar,

We appreciate your response, but I am yet to see a PR. I hope you are working on it, and we will see it soon.

yes i working on it

[proffapt]

@gwydion67 is this error handled in your updates? Basically if i run the script twice an academic session - referring to two semesters - will some of the events/holidays be duplicated?

[gwydion67]

Exactly this is not handled.

The other pr for google Calendar rewrite has option to add only current sem calendar or full year calendar to google calendar but generated ics is still for full year.

But that also, since requires manual input would only work in cli