-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location for classrooms/venues #4
Comments
Since most of the times the location is a room number, if you show it on a map, it will point to the "Nalanda Classroom Complex" or "Vikramshila" which isn't that helpful. |
Hey, it popped up in my mail today. One friend from KOSS is already working on an android/ios app for this. |
We can definitely add the location using a JSON of the places that classes can be held at. We should try to compile that, for eg, latlong for the departments, Nalanda, CIC, Vikramshila classrooms etc. If we have that, we can compare the venue to that and then put it in here. (Location previews on Google Calendar also look pretty, so I am down for this.) Can you put up a list of todo items in the description of this issue? |
Hey! @icyflame, let's compile it on a wiki page. |
Todo looks good. Let's begin! Shouldn't take too long to get a small set of lat-longs, then we can implement the functionality here. (Also, we should keep Duplication in mind. I am sure some other department has a room called N241 etc) |
Didn't get, can someone provide context for this?
Multiple Departments can have rooms with same name/number. What was the proposed solution for this? Also, I tried to look for such a page but wasn't able to find it. Does that page exist? If it does, please share the link. |
what is the status of this issue? |
Hello Shikhar, thanks for your interest in contributing. Yes, no one is working on the issue. You can take it up. @chirag-ghosh and @rajivharlalka can help you. |
Alright, I am up for it. Can you brief a little what are the tasks? |
Sure @shikharsoni07 . So currently if you run the code, the location you get is the just the classroom name from the erp timetable. There is a The idea is that along with the name of the classroom (and the building name), we also provide the latitude-longitude of the place in the calendar so that it will be easier for people to locate it. |
What's the status of this? Is it partially done or is it done the best it could be? Because I saw some locations being updated for common places like nalanda. cc: @shikharish |
Nalanda and Vikramshila is done. I think that is enough. |
Sure then, let's then keep this issue for the longer plan. |
Like currently it shows N241 and likewise.
If we add the proper lat-lng, it can be shown in Google Maps.
Progress Tracker:
The text was updated successfully, but these errors were encountered: