Ensure BMH name is a valid DNS hostname

nerok · nerok · commit af3791dc304c · 2025-08-26T21:40:00.000+02:00
Signed-off-by: Didrik Frimann Barroso Koren &lt;didrikfbk@gmail.com&gt;
diff --git a/internal/webhooks/metal3.io/v1alpha1/baremetalhost_validation.go b/internal/webhooks/metal3.io/v1alpha1/baremetalhost_validation.go
@@ -184,9 +184,9 @@ func validateRAID(r *metal3api.RAIDConfig) []error {
 }
 
 func validateBMHName(bmhname string) error {
-	invalidname, _ := regexp.MatchString(`[^A-Za-z0-9\.\-\_]`, bmhname)
+	invalidname, _ := regexp.MatchString(`[^A-Za-z0-9\-]`, bmhname)
 	if invalidname {
-		return errors.New("BareMetalHost resource name cannot contain characters other than [A-Za-z0-9._-]")
+		return errors.New("BareMetalHost resource name cannot contain characters other than [A-Za-z0-9-] to remain DNS hostname compatible with RFC1035")
 	}
 
 	_, err := uuid.Parse(bmhname)

Original file line number	Diff line number	Diff line change
`@@ -184,9 +184,9 @@ func validateRAID(r *metal3api.RAIDConfig) []error {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`func validateBMHName(bmhname string) error {`
`187`		- invalidname, _ := regexp.MatchString(`[^A-Za-z0-9\.\-\_]`, bmhname)
	`187`	+ invalidname, _ := regexp.MatchString(`[^A-Za-z0-9\-]`, bmhname)
`188`	`188`	`if invalidname {`
`189`		`- return errors.New("BareMetalHost resource name cannot contain characters other than [A-Za-z0-9._-]")`
	`189`	`+ return errors.New("BareMetalHost resource name cannot contain characters other than [A-Za-z0-9-] to remain DNS hostname compatible with RFC1035")`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`_, err := uuid.Parse(bmhname)`