E2E: Serial log collection fails because of wrong path

[lentzi90]

We are collecting serial logs for BareMetalHosts here:

cluster-api-provider-metal3/test/e2e/logcollector.go

Line 44 in fa38c5d

serialLog := fmt.Sprintf("/var/log/libvirt/qemu/%s-serial0.log", VMName)

Unfortunately, the VMName ended up including the namespace at some point and that means we do not find the file.
It looks like this:

[2025-03-27T23:06:43.031Z]   �[1mSTEP:�[0m Dumping logs from the "clusterctl-upgrade-management-edqjap" workload cluster �[38;5;243m@ 03/27/25 23:06:42.351�[0m
[2025-03-27T23:06:43.031Z] Failed to get logs for Machine clusterctl-upgrade-management-edqjap-z5jd9, Cluster clusterctl-upgrade-8lq27e/clusterctl-upgrade-management-edqjap: error finding the serial log: stat /var/log/libvirt/qemu/clusterctl_upgrade_8lq27e/node_0-serial0.log: no such file or directory
[2025-03-27T23:06:43.031Z] Failed to get logs for Machine clusterctl-upgrade-management-edqjap-zfbkc-4fb8r, Cluster clusterctl-upgrade-8lq27e/clusterctl-upgrade-management-edqjap: error finding the serial log: stat /var/log/libvirt/qemu/clusterctl_upgrade_8lq27e/node_1-serial0.log: no such file or directory

NOTE: This is only an issue with clusterctl-upgrade tests from what I can tell. This means that special care should be taken to make sure we keep the other tests working when fixing clusterctl-upgrade!

/triage accepted
/help

[metal3-io-bot]

@lentzi90:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

Details

In response to this:

We are collecting serial logs for BareMetalHosts here:

cluster-api-provider-metal3/test/e2e/logcollector.go

Line 44 in fa38c5d

serialLog := fmt.Sprintf("/var/log/libvirt/qemu/%s-serial0.log", VMName)

Unfortunately, the VMName ended up including the namespace at some point and that means we do not find the file. The issue is hidden at the moment by missing folders, this is fixed in https://github.com/metal3-io/cluster-api-provider-metal3/pull/2382/files#diff-f5b805edcde192acfcb1387940ba3c886775a3c02d21dd86dbda796b1422c246.
We should fix this once that is merged.

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[lentzi90]

/remove-lifecycle stale

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[lentzi90]

/remove-lifecycle stale

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[lentzi90]

@adilGhaffarDev have you checked this when working on the log collection? I have not checked if it is fixed or still an issue.