Support utility images repo for running e2e keywords

[tuminoid]

We have keepalived etc in utility-images repo and practically no way of testing the changes in them. Support utility images repo for running e2e keywords.

1. Make sure the utility images repo works as tested_repo and changes get tests
2. Add proper keyword triggers for Prow

[Rozzii]

I think e2e is overkill for testing a keeplaived PR, instead I would like to do this: metal3-io/utility-images#39

[tuminoid]

I would like to do this instead. I think e2e is overkill for testing a keeplaived PR, instead I would like to do this: metal3-io/utility-images#39

Note that this is utility-images scope issue, while the linked one is keepalived scope issue.

I was thinking e2e in terms of simplicity to implement, just reusing what we have vs implementing the whole new thing. Either is fine though, the end goal is that the changes in utility-images repo should be testable.

[Rozzii]

Indeed this issue is utility image level, I have just had keepalived in mind as I have seen this issue linked on the metal3-io/utility-images#32 .

As far as I can tell, the only tool where it makes sense to re-use our existing tests is fake-ipa where we can take advantage of the the scalability test. But technically scalability test is not an e2e test because the second "e" is faked.

iPXE builder is not used in any of our tests and for keepalived I have mentioned my approach above.

I agree we need testing in utility images but I would not mix our e2e into it at the moment. I would go with new tests.

[Rozzii]

@dtantsur has suggested using the IrSO tests (extending and/or adopting) to test some utility images. That could work IMO we can test keepalived and the pxe builder with IrSO e2e, and for fake API we could use the capm3 scalability tests .

[Rozzii]

/triage accepted