Move sushy-tools image here

[lentzi90]

Currently, we build the sushy-tools image from the ironic-image repo. I think it would make more sense to move it here.

We should also think about the versioning. Currently the sushy-tools version is hard coded even though we build and push the image with the latest tag. This is quite confusing. I suggest that we add support for building the latest code, and that for tagged versions we set the version as tag for the image.

[elfosardo]

the versioning is not hard-coded, there's an ARG associated to it that can be easily overridden.
we set a stable version there because, well, it's stable! (kind of) :)
in ironic upstream we test master directlybut only in the sushy-tools repo because of how the jobs are correlated between each other, but I would not feel comfortable doing the same here.
I don't find using latest confusing, but if we want to change it I propose to instead assign the name of the image based on sushy-tools version.
IMHO considering that sushy-tools is striclty related to ironic, I would leave it in the ironic-image repo.

[lentzi90]

Ok, you are correct, it is not hard coded. That was a bad choice of words. What I meant was that no matter what changes happen in sushy-tools upstream, the "latest" sushy-tools image is always a fixed version.

I don't find using latest confusing, but if we want to change it I propose to instead assign the name of the image based on sushy-tools version.

I'm not sure I understand. Do you mean we would have images like sushy-tools-v2.0.0:latest? That does not make sense to me.
I would want to have the same tag on the image as in the sushy-tools repo. So if sushy-tools is v2.0.0 then the image is sushy-tools:v2.0.0.
We probably don't need to have a master build/image though, as you noted.

[elfosardo]

what I mean is to have the same tag as sushy-tools version, so sushy-tools:2.0.0 in this case should be the same as sushy-tools:latest

[Rozzii]

/triage accepted

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[tuminoid]

/remove-lifecycle stale

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale