Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to add check and ejson package dependencies. #38

Open
eggers opened this issue Sep 26, 2015 · 5 comments
Open

Need to add check and ejson package dependencies. #38

eggers opened this issue Sep 26, 2015 · 5 comments

Comments

@eggers
Copy link

eggers commented Sep 26, 2015

The library won't run without check or ejson, so the dependencies should be explicitly declared.
@markshust
Copy link
Contributor

Created pr for this #39

arunoda added a commit that referenced this issue Oct 27, 2015
@arunoda
Merge pull request #39 from markoshust/feature/38
40080b0 
#38 Adding ejson and check dependencies for Meteor 1.2 support
markshust added a commit to markshust/search-source that referenced this issue Dec 21, 2015
@markshust
Adding ejson and check dependencies for Meteor 1.2 support meteorhack…
8b365b3 
…s#38 meteorhacks#39
@urco
Copy link

urco commented Dec 24, 2015

+1

@markshust
Copy link
Contributor

Can this one be merged in... can close out three tickets

arunoda added a commit that referenced this issue Jan 14, 2016
@arunoda
Merge pull request #49 from markoshust/feature/38
ba12228 
Adding ejson and check dependencies for Meteor 1.2 support #38 #39
@markshust
Copy link
Contributor

fyi, pr #39 added this in, but only for client. i also created #49 for server. sorry about that.

@arunoda
Copy link
Member

arunoda commented Jan 14, 2016

Ah okay.
On 2016 ජන 14, බ්‍රහස් at පෙ.ව. 10.31 Mark Shust [email protected]
wrote:

fyi, pr #39 #39 added
this in, but only for client. i also created #49
#49 for server. sorry
about that.

—
Reply to this email directly or view it on GitHub
#38 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arunoda @markshust @eggers @urco