Succint way to say "either one of or both"

[mickh]

Context: I want to spec a contact map, which can contain either an email address, a phone number, or both. But containing neither is invalid.

I currently have:

[:or
 [:map
  [:email :email]]
 [:map
  [:phone :phone-number]]
 [:map
  [:email :email]
  [:phone :phone-number]]]

which is not very DRY. I'm guessing that I can do better. Any help appreciated.

I know I can use a fn predicate, as in:

[:and
 [:map
  [:email {:optional true} :email]
  [:phone {:optional true} :phone-number]]
 [:fn not-empty]]

but am wondering if I can do it without using a fn predicate.

thanks

[NoahTheDuke]

Could use a local registry. Then the non dry one is much shorter.

[mickh]

Not sure I follow. How would a local registry help?

[NoahTheDuke]

I may have misunderstood your problem. I was thinking that :email and :phone-number are standing in for much longer schemas and the issue is the repetition of the types. But that's not your actual issue, so never mind.

[ikitommi]

Maybe just mark the keys as optional?

[ikitommi]

responded to the original message from email notification, yes, the :fn + :and is a ok way to check no non-emptiness.

[mickh]

Thanks. I was looking to see if there's a way to do it declaratively, but maybe there isn't. Too edge-casey?

[ikitommi]

not easy to do simpler than what is available already I think.

[ikitommi]

there is an existing discussion in this issue: #474

[mickh]

Thanks for the link.