Skip to content

Bug fix and improvement in RectangleObject getWidth() and getHeight() #40

@etienned

Description

@etienned

In generic.py on line 727, it's like that:

def getHeight(self):
    return self.getUpperRight_y() - self.getLowerLeft_x()

And should be like that (the "x" change to "y" at the end):

def getHeight(self):
    return self.getUpperRight_y() - self.getLowerLeft_y()

Also both getWidth() and getHeight() output should be wrap in abs() like that:

def getHeight(self):
    return abs(self.getUpperRight_y() - self.getLowerLeft_y())

And we could add properties to make the thing more pleasant:

@property
def width(self):
    return self.getWidth()

@property
def height(self):
    return self.getHeight()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions