Skip to content

Commit 113df91

Browse files
mgarrardfacebook-github-bot
authored andcommitted
Replace data fetch with lookup (facebook#4788)
Summary: Instead of fetching data we should use lookup for performance reasons. Reviewed By: saitcakmak Differential Revision: D91011958
1 parent 01e35dd commit 113df91

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

ax/generation_strategy/transition_criterion.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,9 +581,8 @@ def is_met(
581581
experiment: Experiment,
582582
curr_node: GenerationNode,
583583
) -> bool:
584-
# TODO: @mgarrard replace fetch_data with lookup_data
585-
data = experiment.fetch_data(
586-
metrics=[experiment.signature_to_metric[self.metric_signature]]
584+
data = experiment.lookup_data().filter(
585+
metric_signatures=[self.metric_signature]
587586
)
588587

589588
count_no = (data.df["mean"] == 0).sum()

0 commit comments

Comments
 (0)