Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid directory names #33

Closed
wants to merge 3 commits into from
Closed

Fix invalid directory names #33

wants to merge 3 commits into from

Conversation

mat007
Copy link

@mat007 mat007 commented Aug 8, 2018 •
edited
Loading

fixes #19

@mat007 mat007 mentioned this pull request Aug 8, 2018
Open
@mat007
Handle directories with a relative path
5fb13d8
@mat007
Move test assets to subdirectory to test directory path
fd9945e
@mat007
Fix error handling
bfaec04 
Use err everywhere for consistency, previously err3 was tested but the error logged was err causing a null pointer panic.
@mat007
Copy link
Author

mat007 commented Aug 8, 2018

Not sure why appveyor fails there:

2018/08/08 02:31:11 makeCmd: C:/go-msi/go-msi.exe [choco --input hello.msi --version 0.0.1 -c "C:\Program Files\changelog\changelog.exe" ghrelease --version 0.0.1 --keep]
2018/08/08 02:31:11 lookPath ok C:/go-msi/go-msi.exe="C:\\go-msi\\go-msi.exe"
The system cannot find the path specified.
Failed to execute command to generate the changelog:"\"C:\\Program Files\\changelog\\changelog.exe\" ghrelease --version 0.0.1"
exit status 1

It isn't due to the changes in this PR as I opened #34 with just the last commit here which fixes the error handling for this exact failure, and it still fails…

@mat007 mat007 closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impossible to list absolute paths to directories
1 participant
@mat007