Prefer unpacking over concatenating

This also opens the door to using more tuples and generators in these places for further optimizations
Used Ruff to prevent regressions

Author: Avasam

.github/workflows/main.yml

@@ -107,6 +107,9 @@ jobs:
       - run: pip install isort pycln
       - run: pycln . --config=pycln.toml --check
       - run: isort . --diff --check-only
+      - uses: chartboost/ruff-action@v1
+        with:
+          version: '0.3.4'
       - uses: psf/black@stable
         with:
           options: "--fast --check --diff --verbose"

.pre-commit-config.yaml

@@ -33,6 +33,11 @@ repos:
       - id: isort
         name: isort (python)
         verbose: true
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.3.4
+    hooks:
+      - id: ruff # Run the linter.
+        args: [--fix]
   - repo: https://github.com/psf/black-pre-commit-mirror
     rev: 24.2.0
     hooks:

Pythonwin/pywin/Demos/ocx/ocxserialtest.py

@@ -68,7 +68,7 @@ def OnComm(self):
 
 class TestSerDialog(dialog.Dialog):
     def __init__(self, *args):
-        dialog.Dialog.__init__(*(self,) + args)
+        dialog.Dialog.__init__(*(self, *args))
         self.olectl = None
 
     def OnComm(self):

Pythonwin/pywin/docking/DockingBar.py

@@ -96,7 +96,7 @@ def CreateWindow(
         self._obj_.CreateWindow(wndClass, title, style, (0, 0, 0, 0), parent, id)
 
         # Create the child dialog
-        self.dialog = childCreator(*(self,) + childCreatorArgs)
+        self.dialog = childCreator(*(self, *childCreatorArgs))
 
         # use the dialog dimensions as default base dimensions
         assert self.dialog.IsWindow(), (

Pythonwin/pywin/framework/editor/color/coloreditor.py

@@ -631,8 +631,9 @@ def GetPythonPropertyPages(self):
         """Returns a list of property pages"""
         from pywin.scintilla import configui
 
-        return EditorTemplateBase.GetPythonPropertyPages(self) + [
-            configui.ScintillaFormatPropertyPage()
+        return [
+            *EditorTemplateBase.GetPythonPropertyPages(self),
+            configui.ScintillaFormatPropertyPage(),
         ]
 
 

Pythonwin/pywin/framework/interact.py

@@ -477,7 +477,7 @@ def ExtractCommand(self, lines):
         while end >= start:
             thisLine = self.DoGetLine(end)
             promptLen = len(GetPromptPrefix(thisLine))
-            retList = [thisLine[promptLen:]] + retList
+            retList = [thisLine[promptLen:], *retList]
             end = end - 1
         return retList
 

Pythonwin/pywin/scintilla/config.py

@@ -175,7 +175,7 @@ def configure(self, editor, subsections=None):
         # First, we "recursively" connect any we are based on.
         if subsections is None:
             subsections = []
-        subsections = [""] + subsections
+        subsections = ["", *subsections]
         general = self.get_data("general")
         if general:
             parents = general.get("based on", [])
@@ -224,7 +224,7 @@ def configure(self, editor, subsections=None):
     def get_key_binding(self, event, subsections=None):
         if subsections is None:
             subsections = []
-        subsections = [""] + subsections
+        subsections = ["", *subsections]
 
         subsection_keymap = self.get_data("keys")
         for subsection in subsections:

Pythonwin/pywin/tools/TraceCollector.py

@@ -38,7 +38,7 @@ def CollectorThread(stopEvent, file):
 
 class WindowOutput(winout.WindowOutput):
     def __init__(self, *args):
-        winout.WindowOutput.__init__(*(self,) + args)
+        winout.WindowOutput.__init__(*(self, *args))
         self.hStopThread = win32event.CreateEvent(None, 0, 0, None)
         _thread.start_new(CollectorThread, (self.hStopThread, self))
 

com/win32com/client/__init__.py

@@ -565,7 +565,7 @@ def __setattr__(self, attr, value):
             args, defArgs = self._prop_map_put_[attr]
         except KeyError:
             raise AttributeError(f"'{repr(self)}' object has no attribute '{attr}'")
-        self._oleobj_.Invoke(*(args + (value,) + defArgs))
+        self._oleobj_.Invoke(*((*args, value, *defArgs)))
 
     def _get_good_single_object_(self, obj, obUserName=None, resultCLSID=None):
         return _get_good_single_object_(obj, obUserName, resultCLSID)

com/win32com/client/dynamic.py

@@ -213,7 +213,7 @@ def __call__(self, *args):
                 pythoncom.DISPID_VALUE,
             )
         if invkind is not None:
-            allArgs = (dispid, LCID, invkind, 1) + args
+            allArgs = (dispid, LCID, invkind, 1, *args)
             return self._get_good_object_(
                 self._oleobj_.Invoke(*allArgs), self._olerepr_.defaultDispatchName, None
             )
@@ -335,7 +335,7 @@ def __setitem__(self, index, *args):
                 pythoncom.DISPID_VALUE,
             )
         if invkind is not None:
-            allArgs = (dispid, LCID, invkind, 0, index) + args
+            allArgs = (dispid, LCID, invkind, 0, index, *args)
             return self._get_good_object_(
                 self._oleobj_.Invoke(*allArgs), self._olerepr_.defaultDispatchName, None
             )
@@ -358,7 +358,7 @@ def _find_dispatch_type_(self, methodName):
 
     def _ApplyTypes_(self, dispid, wFlags, retType, argTypes, user, resultCLSID, *args):
         result = self._oleobj_.InvokeTypes(
-            *(dispid, LCID, wFlags, retType, argTypes) + args
+            *(dispid, LCID, wFlags, retType, argTypes, *args)
         )
         return self._get_good_object_(result, user, resultCLSID)
 
@@ -451,7 +451,7 @@ def _proc_(self, name, *args):
             item = self._olerepr_.mapFuncs[name]
             dispId = item.dispid
             return self._get_good_object_(
-                self._oleobj_.Invoke(*(dispId, LCID, item.desc[4], 0) + (args))
+                self._oleobj_.Invoke(*(dispId, LCID, item.desc[4], 0, *args))
             )
         except KeyError:
             raise AttributeError(name)