-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quoted header values containing commas and comprised of the same string aren't able to be parsed. #1052
Comments
This describes my issue as well. Can reproduce on the demo site. Should be noted that My test snippet:
Adjusting the second instance of |
I think I have the same issue #1055 any way to fix? |
We control the template we're parsing, so we just removed the duplicate strings in the headers. Alternatively, you could do |
i don't understand why this is happening, it should take the value from pipe to pipe regarldess of mismatched quotation marks. I need headers, so I cannot disable them, but It looks like a basic feature. Maybe I can escape the " somehow? |
And updated test to match the improved renaming logic.
Would love to see this get addressed, looks like there's an open PR that will fix it? |
This is a pretty weird corner case, so let me know if y'all need more detail. Given a sheet with headers named
"Bar, Baz"
and"Spam, Baz"
, after splitting the header row on,
, Papa will treatBaz"
as duplicate header, and append_1
to the second instance of it inheaderMap
. Then while seemingly attempting to remediate duplicates, the second header value will become"Spam, Baz"_1
, and seems to break parsing fields later on. The following scirpt...... will print...
I was going to submit a PR, but the code is a bit difficult to follow. If this will take some time for y'all to get to, just comment here, and I can spend some time on a PR.
The text was updated successfully, but these errors were encountered: