Skip to content

Commit 6b6bd9e

Browse files
yangx-jygregkh
authored andcommitted
RDMA/rxe: Generate a completion for unsupported/invalid opcode
commit 2f917af777011c88e977b9b9a5d00b280d3a59ce upstream. Current rxe_requester() doesn't generate a completion when processing an unsupported/invalid opcode. If rxe driver doesn't support a new opcode (e.g. RDMA Atomic Write) and RDMA library supports it, an application using the new opcode can reproduce this issue. Fix the issue by calling "goto err;". Fixes: 8700e3e ("Soft RoCE driver") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Xiao Yang <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 9af670b commit 6b6bd9e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/infiniband/sw/rxe/rxe_req.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,7 @@ int rxe_requester(void *arg)
677677
opcode = next_opcode(qp, wqe, wqe->wr.opcode);
678678
if (unlikely(opcode < 0)) {
679679
wqe->status = IB_WC_LOC_QP_OP_ERR;
680-
goto exit;
680+
goto err;
681681
}
682682

683683
mask = rxe_opcode[opcode].mask;

0 commit comments

Comments
 (0)