Skip to content

Commit 847e0f9

Browse files
rddunlapgregkh
authored andcommitted
powerpc/idle: Fix return value of __setup() handler
[ Upstream commit b793a01000122d2bd133ba451a76cc135b5e162c ] __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument or environment strings. Also, error return codes don't mean anything to obsolete_checksetup() -- only non-zero (usually 1) or zero. So return 1 from powersave_off(). Fixes: 302eca1 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop") Reported-by: Igor Zhbanov <[email protected]> Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sasha Levin <[email protected]>
1 parent 2c7f454 commit 847e0f9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/powerpc/kernel/idle.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ static int __init powersave_off(char *arg)
4141
{
4242
ppc_md.power_save = NULL;
4343
cpuidle_disable = IDLE_POWERSAVE_OFF;
44-
return 0;
44+
return 1;
4545
}
4646
__setup("powersave=off", powersave_off);
4747

0 commit comments

Comments
 (0)