Skip to content

Commit 3770b7f

Browse files
authored
Merge pull request #321 from bls337/main
Fix getImagingCameras() method
2 parents f49e1fd + a20c137 commit 3770b7f

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/main/java/org/micromanager/lightsheetmanager/model/DeviceManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,11 +275,11 @@ public CameraBase[] getImagingCameras() {
275275
for (int j = 0; j < numCameras; j++) {
276276
String cameraName = "Imaging";
277277
if (numImagingPaths > 1) {
278-
cameraName += String.valueOf(i);
278+
cameraName += String.valueOf(i + 1);
279279
}
280280
cameraName += "Camera";
281281
if (numCameras > 1) {
282-
cameraName += String.valueOf(j);
282+
cameraName += String.valueOf(j + 1);
283283
}
284284
cameraNames.add((CameraBase)deviceMap_.get(cameraName));
285285
}

src/main/java/org/micromanager/lightsheetmanager/model/acquisitions/AcquisitionEngineSCAPE.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,8 +1101,12 @@ public DefaultTimingSettings.Builder getTimingFromPeriodAndLightExposure() {
11011101
// just a dummy to test demo mode
11021102
return new DefaultTimingSettings.Builder();
11031103
}
1104-
// TODO: do this in ui?
1105-
camera.setTriggerMode(acqSettings_.cameraMode());
1104+
1105+
// TODO: is this necessary? setTriggerMode is called in doHardwareCalculations too
1106+
CameraBase[] cameras = model_.devices().getImagingCameras();
1107+
for (CameraBase cam : cameras) {
1108+
cam.setTriggerMode(acqSettings_.cameraMode());
1109+
}
11061110

11071111
// TODO: camera.getTriggerMode(); does not match up with actual selected trigger mode for PVCAM (pseudo overlap reads as edge trigger)
11081112
//System.out.println(camera.getDeviceName());

0 commit comments

Comments
 (0)