pre-commit updates (#953)

bpkroth · pre-commit-ci[bot] · web-flow · commit e7751fdfc3bb · 2025-02-22T00:59:57.000Z
# Pull Request

## Title

pre-commit updates

______________________________________________________________________

## Description

- hook version updates
- add badge

______________________________________________________________________

---------

Co-authored-by: pre-commit-ci[bot] &lt;66853113+pre-commit-ci[bot]@users.noreply.github.com&gt;
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -157,10 +157,23 @@ jobs:
           'from sys import version_info as vers; assert (vers.major, vers.minor) == (3, 13), f"Unexpected python version: {vers}"'
 
     # This is moreso about code cleanliness, which is a dev thing, not a
-    # functionality thing, and the rules for that change between python versions,
-    # so only do this for the default in the devcontainer.
-    #- name: Run lint checks
-    #  run: make CONDA_ENV_NAME=$CONDA_ENV_NAME check
+    # functionality thing, and the rules for that sometimes change between
+    # python versions, so only do this for the default python in addition to the
+    # devcontainer to get an earlier PR status signal.
+
+    - name: Check for formatting issues
+      if: ${{ matrix.python_version == '' }}
+      timeout-minutes: 3
+      run: |
+        set -x
+        make CONDA_ENV_NAME=$CONDA_ENV_NAME format
+        # licenseheaders changes the contents of the files, so make this check fail if there are any changes detected
+        git --no-pager diff --exit-code
+
+    - name: Run lint checks
+      if: ${{ matrix.python_version == '' }}
+      timeout-minutes: 5
+      run: make CONDA_ENV_NAME=$CONDA_ENV_NAME check
 
     # Only run the coverage checks on the devcontainer job.
     - name: Run tests
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -81,14 +81,14 @@ repos:
         args: [--py310-plus]
         stages: [pre-commit, manual]
 -   repo: https://github.com/PyCQA/isort
-    rev: 5.13.2
+    rev: 6.0.0
     hooks:
     -   id: isort
         require_serial: true
         args: ["-j", "-1"]
         stages: [pre-commit, manual]
 -   repo: https://github.com/psf/black
-    rev: 24.10.0
+    rev: 25.1.0
     hooks:
     -   id: black
         stages: [pre-commit, manual]
@@ -98,9 +98,10 @@ repos:
     -   id: docformatter
         stages: [pre-commit, manual]
 -   repo: https://github.com/executablebooks/mdformat
-    rev: 0.7.17
+    rev: 0.7.22
     hooks:
       - id: mdformat
+        stages: [pre-commit, manual]
         additional_dependencies:
           - mdformat-gfm
           - mdformat-black
diff --git a/Makefile b/Makefile
@@ -73,7 +73,7 @@ FORMAT_COMMON_PREREQS += $(MLOS_GLOBAL_CONF_FILES)
 
 # Formatting pre-commit hooks are marked with the "manual" stage in .pre-commit-config.yaml
 # Since yq is not installed everywhere we need to sync the list here as well.
-FORMATTERS := end-of-file-fixer pretty-format-json trailingwhitespace licenseheaders pyupgrade isort black docformatter
+FORMATTERS := end-of-file-fixer pretty-format-json trailingwhitespace licenseheaders pyupgrade isort black docformatter mdformat
 
 # Provide convenience methods to call individual formatters and checkers via `make` as well.
 # e.g., `make black` or `make pylint`
diff --git a/README.md b/README.md
@@ -5,6 +5,7 @@
 [![MLOS MacOS](https://github.com/microsoft/MLOS/actions/workflows/macos.yml/badge.svg)](https://github.com/microsoft/MLOS/actions/workflows/macos.yml)
 [![MLOS Windows](https://github.com/microsoft/MLOS/actions/workflows/windows.yml/badge.svg)](https://github.com/microsoft/MLOS/actions/workflows/windows.yml)
 [![Code Coverage Status](https://microsoft.github.io/MLOS/_images/coverage.svg)](https://microsoft.github.io/MLOS/htmlcov/index.html)
+[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/microsoft/MLOS/main.svg)](https://results.pre-commit.ci/latest/github/microsoft/MLOS/main)
 
 MLOS is a project to enable autotuning for systems.
 
diff --git a/SECURITY.md b/SECURITY.md
@@ -12,7 +12,7 @@ If you believe you have found a security vulnerability in any Microsoft-owned re
 
 Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://msrc.microsoft.com/create-report).
 
-If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com).  If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
+If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com). If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
 
 You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://www.microsoft.com/msrc).
 
diff --git a/conda-envs/mlos-3.10.yml b/conda-envs/mlos-3.10.yml
@@ -25,11 +25,12 @@ dependencies:
     - check-jsonschema
     # Fixed versions for easier maintainability.
     # Dependabot can update explicitly as necessary.
-    - pre-commit==4.0.1
+    - pre-commit==4.1.0
     - pycodestyle==2.12.1
-    - pylint==3.3.3
+    - pylint==3.3.4
     - tomlkit
-    - mypy==1.14.1
+    - mypy==1.15.0
+    - pyright==1.1.394
     - pandas-stubs
     - types-beautifulsoup4
     - types-colorama
diff --git a/conda-envs/mlos-3.11.yml b/conda-envs/mlos-3.11.yml
@@ -25,11 +25,12 @@ dependencies:
     - check-jsonschema
     # Fixed versions for easier maintainability.
     # Dependabot can update explicitly as necessary.
-    - pre-commit==4.0.1
+    - pre-commit==4.1.0
     - pycodestyle==2.12.1
-    - pylint==3.3.3
+    - pylint==3.3.4
     - tomlkit
-    - mypy==1.14.1
+    - mypy==1.15.0
+    - pyright==1.1.394
     - pandas-stubs
     - types-beautifulsoup4
     - types-colorama
diff --git a/conda-envs/mlos-3.12.yml b/conda-envs/mlos-3.12.yml
@@ -27,11 +27,12 @@ dependencies:
     - check-jsonschema
     # Fixed versions for easier maintainability.
     # Dependabot can update explicitly as necessary.
-    - pre-commit==4.0.1
+    - pre-commit==4.1.0
     - pycodestyle==2.12.1
-    - pylint==3.3.3
+    - pylint==3.3.4
     - tomlkit
-    - mypy==1.14.1
+    - mypy==1.15.0
+    - pyright==1.1.394
     - pandas-stubs
     - types-beautifulsoup4
     - types-colorama
diff --git a/conda-envs/mlos-3.13.yml b/conda-envs/mlos-3.13.yml
@@ -27,11 +27,12 @@ dependencies:
     - check-jsonschema
     # Fixed versions for easier maintainability.
     # Dependabot can update explicitly as necessary.
-    - pre-commit==4.0.1
+    - pre-commit==4.1.0
     - pycodestyle==2.12.1
-    - pylint==3.3.3
+    - pylint==3.3.4
     - tomlkit
-    - mypy==1.14.1
+    - mypy==1.15.0
+    - pyright==1.1.394
     - pandas-stubs
     - types-beautifulsoup4
     - types-colorama
diff --git a/conda-envs/mlos-windows.yml b/conda-envs/mlos-windows.yml
@@ -28,11 +28,12 @@ dependencies:
     - check-jsonschema
     # Fixed versions for easier maintainability.
     # Dependabot can update explicitly as necessary.
-    - pre-commit==4.0.1
+    - pre-commit==4.1.0
     - pycodestyle==2.12.1
-    - pylint==3.3.3
+    - pylint==3.3.4
     - tomlkit
-    - mypy==1.14.1
+    - mypy==1.15.0
+    - pyright==1.1.394
     - pandas-stubs
     - types-beautifulsoup4
     - types-colorama
diff --git a/conda-envs/mlos.yml b/conda-envs/mlos.yml
@@ -23,12 +23,12 @@ dependencies:
     - check-jsonschema
     # Fixed versions for easier maintainability.
     # Dependabot can update explicitly as necessary.
-    - pre-commit==4.0.1
+    - pre-commit==4.1.0
     - pycodestyle==2.12.1
-    - pylint==3.3.3
+    - pylint==3.3.4
     - tomlkit
-    - mypy==1.14.1
-    - pyright==1.1.392.post0
+    - mypy==1.15.0
+    - pyright==1.1.394
     - pandas-stubs
     - types-beautifulsoup4
     - types-colorama
diff --git a/mlos_bench/mlos_bench/services/config_persistence.py b/mlos_bench/mlos_bench/services/config_persistence.py
@@ -422,7 +422,7 @@ def build_environment(
         parent_args: dict[str, TunableValue] | None = None,
         service: Service | None = None,
     ) -> Environment:
-        # pylint: disable=too-many-arguments
+        # pylint: disable=too-many-arguments,too-many-positional-arguments
         """
         Factory method for a new :py:class:`.Environment` with a given config.
 
@@ -594,7 +594,7 @@ def load_environment(
         parent_args: dict[str, TunableValue] | None = None,
         service: Service | None = None,
     ) -> Environment:
-        # pylint: disable=too-many-arguments
+        # pylint: disable=too-many-arguments,too-many-positional-arguments
         """
         Load and build new :py:class:`.Environment` from the config file or JSON string.
 
@@ -633,7 +633,7 @@ def load_environment_list(
         parent_args: dict[str, TunableValue] | None = None,
         service: Service | None = None,
     ) -> list[Environment]:
-        # pylint: disable=too-many-arguments
+        # pylint: disable=too-many-arguments,too-many-positional-arguments
         """
         Load and build a list of Environments from the config file or JSON string.
 
diff --git a/mlos_bench/mlos_bench/storage/sql/alembic/versions/8928a401115b_adding_experiment_table_columns_to_.py b/mlos_bench/mlos_bench/storage/sql/alembic/versions/8928a401115b_adding_experiment_table_columns_to_.py
@@ -9,6 +9,7 @@
 Create Date: 2025-01-14 17:06:36.181503+00:00
 
 """
+# pylint: disable=invalid-name
 # pylint: disable=no-member
 
 from collections.abc import Sequence
diff --git a/mlos_core/mlos_core/spaces/adapters/README.md b/mlos_core/mlos_core/spaces/adapters/README.md
@@ -44,14 +44,14 @@ llamatune_optimizer = OptimizerFactory.create(
     optimizer_kwargs={
         # optimizer kwargs
         # e.g.,
-        max_trials=100,
+        "max_trials": 100,
     },
     space_adapter_type=SpaceAdapterType.LLAMATUNE,
     space_adapter_kwargs={
         # llamatune kwargs
         # e.g.,
-        num_low_dims=16,
-        special_param_values={
+        "num_low_dims": 16,
+        "special_param_values": {
             "special_param": [-1, 0],
         },
     },

-Original file line number
+Diff line change
 Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://msrc.microsoft.com/create-report).
 -If you prefer to submit without logging in, send email to [[email protected]](mailto:[email protected]).  If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
 +If you prefer to submit without logging in, send email to [[email protected]](mailto:[email protected]). If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://www.microsoft.com/en-us/msrc/pgp-key-msrc).
 You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://www.microsoft.com/msrc).