Add validation and diagnostics for import attribute mismatches

Implements error reporting when import attributes don't match between
import statements and ambient module declarations.

Changes:
- Added diagnostic messages TS18062 and TS18063 for attribute mismatches
- Updated resolveExternalModule to report TS18063 when pattern matches
  but attributes don't match
- Created comprehensive test cases for diagnostic error messages

The diagnostic TS18063 is reported when:
- Pattern matches but attribute values are different
- Pattern matches but import has no attributes when declaration requires them
- Pattern matches but import has attributes when declaration doesn't
- Pattern matches but attributes have different keys or values

Author: jonathantneal

src/compiler/checker.ts

@@ -4875,7 +4875,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                         return false;
                     });
                     if (!hasMatchingDeclaration) {
-                        // Pattern matched but attributes don't match - continue searching
+                        // Pattern matched but attributes don't match
+                        if (errorNode && moduleNotFoundError) {
+                            error(errorNode, Diagnostics.No_ambient_module_declaration_matches_import_of_0_with_the_specified_import_attributes, moduleReference);
+                        }
                         return undefined;
                     }
                 }

src/compiler/diagnosticMessages.json

@@ -8547,5 +8547,13 @@
     "'{0}' is not a valid meta-property for keyword 'import'. Did you mean 'meta' or 'defer'?": {
         "category": "Error",
         "code": 18061
+    },
+    "Module '{0}' was resolved to '{1}', but import attributes do not match the ambient module declaration.": {
+        "category": "Error",
+        "code": 18062
+    },
+    "No ambient module declaration matches import of '{0}' with the specified import attributes.": {
+        "category": "Error",
+        "code": 18063
     }
 }

tests/baselines/reference/ambientModuleWithImportAttributesDiagnostics.errors.txt

@@ -0,0 +1,45 @@
+test.ts(2,21): error TS18063: No ambient module declaration matches import of 'styles.css' with the specified import attributes.
+test.ts(5,21): error TS18063: No ambient module declaration matches import of 'styles2.css' with the specified import attributes.
+test.ts(8,18): error TS18063: No ambient module declaration matches import of 'file.txt' with the specified import attributes.
+test.ts(11,18): error TS18063: No ambient module declaration matches import of 'data.json' with the specified import attributes.
+
+
+==== types.d.ts (0 errors) ====
+    // Declare ambient modules with import attributes
+    declare module "*.css" with { type: "css" } {
+        const stylesheet: CSSStyleSheet;
+        export default stylesheet;
+    }
+    
+    declare module "*.json" with { type: "json" } {
+        const data: any;
+        export default data;
+    }
+    
+    declare module "*.txt" {
+        const content: string;
+        export default content;
+    }
+    
+==== test.ts (4 errors) ====
+    // Should error - pattern matches but attributes don't match
+    import styles1 from "styles.css" with { type: "style" };
+                        ~~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'styles.css' with the specified import attributes.
+    
+    // Should error - pattern matches but import has no attributes when declaration requires them
+    import styles2 from "styles2.css";
+                        ~~~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'styles2.css' with the specified import attributes.
+    
+    // Should error - pattern matches but import has attributes when declaration doesn't
+    import text from "file.txt" with { type: "text" };
+                     ~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'file.txt' with the specified import attributes.
+    
+    // Should error - pattern matches but attribute value is wrong
+    import data from "data.json" with { type: "data" };
+                     ~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'data.json' with the specified import attributes.
+    
+    

tests/baselines/reference/ambientModuleWithImportAttributesDiagnostics.js

@@ -0,0 +1,40 @@
+//// [tests/cases/conformance/ambient/ambientModuleWithImportAttributesDiagnostics.ts] ////
+
+//// [types.d.ts]
+// Declare ambient modules with import attributes
+declare module "*.css" with { type: "css" } {
+    const stylesheet: CSSStyleSheet;
+    export default stylesheet;
+}
+
+declare module "*.json" with { type: "json" } {
+    const data: any;
+    export default data;
+}
+
+declare module "*.txt" {
+    const content: string;
+    export default content;
+}
+
+//// [test.ts]
+// Should error - pattern matches but attributes don't match
+import styles1 from "styles.css" with { type: "style" };
+
+// Should error - pattern matches but import has no attributes when declaration requires them
+import styles2 from "styles2.css";
+
+// Should error - pattern matches but import has attributes when declaration doesn't
+import text from "file.txt" with { type: "text" };
+
+// Should error - pattern matches but attribute value is wrong
+import data from "data.json" with { type: "data" };
+
+
+
+//// [test.js]
+export {};
+
+
+//// [test.d.ts]
+export {};

tests/baselines/reference/ambientModuleWithImportAttributesDiagnostics.symbols

@@ -0,0 +1,53 @@
+//// [tests/cases/conformance/ambient/ambientModuleWithImportAttributesDiagnostics.ts] ////
+
+=== types.d.ts ===
+// Declare ambient modules with import attributes
+declare module "*.css" with { type: "css" } {
+>"*.css" : Symbol("*.css", Decl(types.d.ts, 0, 0))
+
+    const stylesheet: CSSStyleSheet;
+>stylesheet : Symbol(stylesheet, Decl(types.d.ts, 2, 9))
+>CSSStyleSheet : Symbol(CSSStyleSheet, Decl(lib.dom.d.ts, --, --), Decl(lib.dom.d.ts, --, --))
+
+    export default stylesheet;
+>stylesheet : Symbol(stylesheet, Decl(types.d.ts, 2, 9))
+}
+
+declare module "*.json" with { type: "json" } {
+>"*.json" : Symbol("*.json", Decl(types.d.ts, 4, 1))
+
+    const data: any;
+>data : Symbol(data, Decl(types.d.ts, 7, 9))
+
+    export default data;
+>data : Symbol(data, Decl(types.d.ts, 7, 9))
+}
+
+declare module "*.txt" {
+>"*.txt" : Symbol("*.txt", Decl(types.d.ts, 9, 1))
+
+    const content: string;
+>content : Symbol(content, Decl(types.d.ts, 12, 9))
+
+    export default content;
+>content : Symbol(content, Decl(types.d.ts, 12, 9))
+}
+
+=== test.ts ===
+// Should error - pattern matches but attributes don't match
+import styles1 from "styles.css" with { type: "style" };
+>styles1 : Symbol(styles1, Decl(test.ts, 1, 6))
+
+// Should error - pattern matches but import has no attributes when declaration requires them
+import styles2 from "styles2.css";
+>styles2 : Symbol(styles2, Decl(test.ts, 4, 6))
+
+// Should error - pattern matches but import has attributes when declaration doesn't
+import text from "file.txt" with { type: "text" };
+>text : Symbol(text, Decl(test.ts, 7, 6))
+
+// Should error - pattern matches but attribute value is wrong
+import data from "data.json" with { type: "data" };
+>data : Symbol(data, Decl(test.ts, 10, 6))
+
+

tests/baselines/reference/ambientModuleWithImportAttributesDiagnostics.types

@@ -0,0 +1,71 @@
+//// [tests/cases/conformance/ambient/ambientModuleWithImportAttributesDiagnostics.ts] ////
+
+=== types.d.ts ===
+// Declare ambient modules with import attributes
+declare module "*.css" with { type: "css" } {
+>"*.css" : typeof import("*.css")
+>        : ^^^^^^^^^^^^^^^^^^^^^^
+
+    const stylesheet: CSSStyleSheet;
+>stylesheet : CSSStyleSheet
+>           : ^^^^^^^^^^^^^
+
+    export default stylesheet;
+>stylesheet : CSSStyleSheet
+>           : ^^^^^^^^^^^^^
+}
+
+declare module "*.json" with { type: "json" } {
+>"*.json" : typeof import("*.json")
+>         : ^^^^^^^^^^^^^^^^^^^^^^^
+
+    const data: any;
+>data : any
+>     : ^^^
+
+    export default data;
+>data : any
+>     : ^^^
+}
+
+declare module "*.txt" {
+>"*.txt" : typeof import("*.txt")
+>        : ^^^^^^^^^^^^^^^^^^^^^^
+
+    const content: string;
+>content : string
+>        : ^^^^^^
+
+    export default content;
+>content : string
+>        : ^^^^^^
+}
+
+=== test.ts ===
+// Should error - pattern matches but attributes don't match
+import styles1 from "styles.css" with { type: "style" };
+>styles1 : any
+>        : ^^^
+>type : any
+>     : ^^^
+
+// Should error - pattern matches but import has no attributes when declaration requires them
+import styles2 from "styles2.css";
+>styles2 : any
+>        : ^^^
+
+// Should error - pattern matches but import has attributes when declaration doesn't
+import text from "file.txt" with { type: "text" };
+>text : any
+>     : ^^^
+>type : any
+>     : ^^^
+
+// Should error - pattern matches but attribute value is wrong
+import data from "data.json" with { type: "data" };
+>data : any
+>     : ^^^
+>type : any
+>     : ^^^
+
+

tests/baselines/reference/ambientModuleWithImportAttributesSemantics.errors.txt

@@ -1,9 +1,14 @@
 test.ts(2,33): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
 test.ts(6,30): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
 test.ts(14,38): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
+test.ts(18,19): error TS18063: No ambient module declaration matches import of 'file2.txt' with the specified import attributes.
 test.ts(18,31): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
+test.ts(22,21): error TS18063: No ambient module declaration matches import of 'styles2.css' with the specified import attributes.
+test.ts(26,21): error TS18063: No ambient module declaration matches import of 'styles3.css' with the specified import attributes.
 test.ts(26,35): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
+test.ts(30,25): error TS18063: No ambient module declaration matches import of 'module2.wasm' with the specified import attributes.
 test.ts(30,40): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
+test.ts(34,25): error TS18063: No ambient module declaration matches import of 'module3.wasm' with the specified import attributes.
 test.ts(34,40): error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
 
 
@@ -32,7 +37,7 @@ test.ts(34,40): error TS2856: Import attributes are not allowed on statements th
         export default module;
     }
 
-==== test.ts (7 errors) ====
+==== test.ts (12 errors) ====
     // Should resolve correctly - matching attributes
     import styles from "styles.css" with { type: "css" };
                                     ~~~~~~~~~~~~~~~~~~~~
@@ -57,28 +62,38 @@ test.ts(34,40): error TS2856: Import attributes are not allowed on statements th
 
     // Should NOT resolve - import has attributes but declaration doesn't
     import text2 from "file2.txt" with { type: "text" };
+                      ~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'file2.txt' with the specified import attributes.
                                   ~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
     text2; // Should be any (no match)
 
     // Should NOT resolve - import has no attributes but declaration does
     import styles2 from "styles2.css";
+                        ~~~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'styles2.css' with the specified import attributes.
     styles2; // Should be any (no match)
 
     // Should NOT resolve - mismatched attribute values
     import styles3 from "styles3.css" with { type: "style" };
+                        ~~~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'styles3.css' with the specified import attributes.
                                       ~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
     styles3; // Should be any (no match)
 
     // Should NOT resolve - missing attribute
     import wasmModule2 from "module2.wasm" with { type: "module" };
+                            ~~~~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'module2.wasm' with the specified import attributes.
                                            ~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
     wasmModule2; // Should be any (no match - missing version attribute)
 
     // Should NOT resolve - extra attribute
     import wasmModule3 from "module3.wasm" with { type: "module", version: "1", extra: "value" };
+                            ~~~~~~~~~~~~~~
+!!! error TS18063: No ambient module declaration matches import of 'module3.wasm' with the specified import attributes.
                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2856: Import attributes are not allowed on statements that compile to CommonJS 'require' calls.
     wasmModule3; // Should be any (no match - extra attribute)

tests/cases/conformance/ambient/ambientModuleWithImportAttributesDiagnostics.ts

@@ -0,0 +1,34 @@
+// @declaration: true
+// @target: es2015
+// @module: esnext
+
+// @filename: types.d.ts
+// Declare ambient modules with import attributes
+declare module "*.css" with { type: "css" } {
+    const stylesheet: CSSStyleSheet;
+    export default stylesheet;
+}
+
+declare module "*.json" with { type: "json" } {
+    const data: any;
+    export default data;
+}
+
+declare module "*.txt" {
+    const content: string;
+    export default content;
+}
+
+// @filename: test.ts
+// Should error - pattern matches but attributes don't match
+import styles1 from "styles.css" with { type: "style" };
+
+// Should error - pattern matches but import has no attributes when declaration requires them
+import styles2 from "styles2.css";
+
+// Should error - pattern matches but import has attributes when declaration doesn't
+import text from "file.txt" with { type: "text" };
+
+// Should error - pattern matches but attribute value is wrong
+import data from "data.json" with { type: "data" };
+