From 2c05f7cf1414592db85e223b66d8f158b1526c17 Mon Sep 17 00:00:00 2001
From: shiranrubin <shiranrubin@microsoft.com>
Date: Thu, 14 Mar 2024 14:07:00 +0000
Subject: [PATCH 1/5] remove none existing link
---
docs/observability/tools/KubernetesDashboards.md | 1 -
1 file changed, 1 deletion(-)
diff --git a/docs/observability/tools/KubernetesDashboards.md b/docs/observability/tools/KubernetesDashboards.md
index f52a0b52fd..5341200342 100644
--- a/docs/observability/tools/KubernetesDashboards.md
+++ b/docs/observability/tools/KubernetesDashboards.md
@@ -36,4 +36,3 @@ There are currently several UI dashboards available to monitor your applications
## References
- [Alternatives to Kubernetes Dashboard](https://octopus.com/blog/alternative-kubernetes-dashboards)
-- [Prometheus and Grafana with Kubernetes](https://tanzu.vmware.com/developer/guides/kubernetes/observability-prometheus-grafana-p1/)
From 7704b78be2e5238d10848f117e2c7509af87d908 Mon Sep 17 00:00:00 2001
From: shiranrubin <shiranrubin@microsoft.com>
Date: Thu, 14 Mar 2024 14:12:20 +0000
Subject: [PATCH 2/5] fix the PR template
---
.github/pull_request_template.md | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 87c65e4ccd..bd76c2cb38 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -12,8 +12,7 @@
- [ ] No confidential information
- [ ] No duplicated content
- [ ] Labeled appropriately
-- [ ] Added 2 reviewers
-- [ ] No lint errors
+- [ ] This PR was reviewed by at least one subject expert
- [ ] No lint check errors related to your changes
> Note: You may see link check errors on pages you have not touched. This is normal, and due to either broken links or sites that reject link checker bots. The reviewer will help you get to a green state on these.
From 20b7a6c47239c38935405b8d39c55ec973d6f090 Mon Sep 17 00:00:00 2001
From: shiranrubin <shiranrubin@microsoft.com>
Date: Thu, 14 Mar 2024 14:20:47 +0000
Subject: [PATCH 3/5] fix rules for code review
---
.github/CODEOWNERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 0696e4308c..dca6b94b71 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1,4 +1,6 @@
+/docs/* @tessferrandez @shiranr @tompaana @nyouens
+
* @tessferrandez @shiranr @nyouens
-/docs/* @tessferrandez @shiranr @tompaana
+
From be66a4b411825c692bb052b2005f880c92b8a973 Mon Sep 17 00:00:00 2001
From: shiranrubin <shiranrubin@microsoft.com>
Date: Thu, 14 Mar 2024 14:22:17 +0000
Subject: [PATCH 4/5] Change megalinter to only go through the changed files
and not entier code base
---
.mega-linter.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.mega-linter.yml b/.mega-linter.yml
index 9501896d5b..d96195d901 100644
--- a/.mega-linter.yml
+++ b/.mega-linter.yml
@@ -20,7 +20,7 @@ SHOW_ELAPSED_TIME: true
FILEIO_REPORTER: false
PARALLEL: true
GITHUB_STATUS_REPORTER: true
-VALIDATE_ALL_CODEBASE: true
+VALIDATE_ALL_CODEBASE: false
LOG_LEVEL: WARNING
MARKDOWN_MARKDOWN_LINK_CHECK_ARGUMENTS: "-q"
# DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass
From 5f2887c02a1155267bdc92847b6ddfa72f143b95 Mon Sep 17 00:00:00 2001
From: Shiran Rubin <shiranrubin@microsoft.com>
Date: Thu, 14 Mar 2024 14:36:22 +0000
Subject: [PATCH 5/5] Update .github/pull_request_template.md
Co-authored-by: Avishay Balter <avishay.balter@gmail.com>
---
.github/pull_request_template.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index bd76c2cb38..57385fd9bf 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -12,7 +12,7 @@
- [ ] No confidential information
- [ ] No duplicated content
- [ ] Labeled appropriately
-- [ ] This PR was reviewed by at least one subject expert
+- [ ] This PR was reviewed by at least one subject matter expert
- [ ] No lint check errors related to your changes
> Note: You may see link check errors on pages you have not touched. This is normal, and due to either broken links or sites that reject link checker bots. The reviewer will help you get to a green state on these.