Fix ListTunnelPorts in Go (#538)

In a for loop, a new address is created for the loopvar. Appending the
pointer of the loopvar to a slice means that every element in the slice
will point to the last element ranged over.

Author: williammartin

go/tunnels/manager.go

@@ -410,8 +410,8 @@ func (m *Manager) ListTunnelPorts(
 		return nil, fmt.Errorf("error parsing response json to tunnel ports: %w", err)
 	}
 
-	for _, port := range tunnelPortsResponse.Value {
-		tp = append(tp, &port)
+	for i := range tunnelPortsResponse.Value {
+		tp = append(tp, &tunnelPortsResponse.Value[i])
 	}
 
 	return tp, nil

go/tunnels/manager_test.go

@@ -653,6 +653,15 @@ func TestTunnelListPorts(t *testing.T) {
 	if len(ports) != 2 {
 		t.Errorf("ports not successfully listed")
 	}
+
+	if ports[0].PortNumber != 3000 {
+		t.Errorf("port 3000 not successfully listed")
+	}
+
+	if ports[1].PortNumber != 3001 {
+		t.Errorf("port 3001 not successfully listed")
+	}
+
 	for _, port := range ports {
 		logger.Printf("Port: %d", port.PortNumber)
 		port.Table().Print()

go/tunnels/tunnels.go

@@ -10,7 +10,7 @@ import (
 	"github.com/rodaine/table"
 )
 
-const PackageVersion = "0.1.18"
+const PackageVersion = "0.1.19"
 
 func (tunnel *Tunnel) requestObject() (*Tunnel, error) {
 	convertedTunnel := &Tunnel{