Remove Device Restore #3953
Merged
Remove Device Restore #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
Oct 21, 2024
tools/SetupFlow/DevHome.SetupFlow/ViewModels/PackageViewModel.cs
Outdated
Show resolved
Hide resolved
lauren-ciha
force-pushed
the
user/laurenciha/remove
branch
from
a152f4a
to
6aabbd9
Compare
lauren-ciha
force-pushed
the
user/laurenciha/remove
branch
from
5803453
to
0a9357d
Compare
AmelBawa-msft
approved these changes
Oct 21, 2024
krschau
reviewed
Oct 22, 2024
| /// <param name="theme">Package icon theme</param> | ||
| /// <returns>Package icon</returns> | ||
| private BitmapImage GetIconByTheme(RestoreApplicationIconTheme theme) | ||
| public BitmapImage GetLightThemeIcon() |
There was a problem hiding this comment.
It's a silly difference but can we do
Suggested change
| public BitmapImage GetLightThemeIcon() | |
| private BitmapImage GetIconByTheme(ElementTheme theme) |
and just call with the right element theme? It's less changed. Also can this method stay private?
tools/SetupFlow/DevHome.SetupFlow/ViewModels/PackageViewModel.cs
Outdated
Show resolved
Hide resolved
lauren-ciha
force-pushed
the
user/laurenciha/remove
branch
from
a7887a7
to
180d8f0
Compare
lauren-ciha
force-pushed
the
user/laurenciha/remove
branch
from
180d8f0
to
59b1cdc
Compare
krschau
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist