Skip to content

Commit 3ee8c69

Browse files
committed
remove override on commit since based and replication implementations are same
1 parent e4a5119 commit 3ee8c69

File tree

2 files changed

+2
-23
lines changed

2 files changed

+2
-23
lines changed

libs/cluster/Server/Replication/ReplicationLogCheckpointManager.cs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -180,27 +180,6 @@ public void CommiLogCheckpointSendFromPrimary(Guid logToken, byte[] checkpointMe
180180
CommitLogCheckpoint(logToken, recoveryInfo.ToByteArray());
181181
}
182182

183-
/// <summary>
184-
/// Commit log checkpoint metadata and append cookie
185-
/// </summary>
186-
/// <param name="logToken"></param>
187-
/// <param name="commitMetadata"></param>
188-
public override unsafe void CommitLogCheckpoint(Guid logToken, byte[] commitMetadata)
189-
{
190-
base.CommitLogCheckpoint(logToken, commitMetadata);
191-
}
192-
193-
/// <summary>
194-
/// Commit incremental log checkpoint metadata and append cookie
195-
/// </summary>
196-
/// <param name="logToken"></param>
197-
/// <param name="commitMetadata"></param>
198-
/// <param name="deltaLog"></param>
199-
public override unsafe void CommitLogIncrementalCheckpoint(Guid logToken, byte[] commitMetadata, DeltaLog deltaLog)
200-
{
201-
base.CommitLogIncrementalCheckpoint(logToken, commitMetadata, deltaLog);
202-
}
203-
204183
/// <summary>
205184
/// Retrieve RecoveredSafeAofAddress and RecoveredReplicationId for checkpoint
206185
/// </summary>

libs/storage/Tsavorite/cs/src/core/Index/CheckpointManagement/DeviceLogCommitCheckpointManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ public byte[] GetIndexCheckpointMetadata(Guid indexToken)
232232
}
233233

234234
/// <inheritdoc />
235-
public virtual unsafe void CommitLogCheckpoint(Guid logToken, byte[] commitMetadata)
235+
public unsafe void CommitLogCheckpoint(Guid logToken, byte[] commitMetadata)
236236
{
237237
var device = NextLogCheckpointDevice(logToken);
238238

@@ -247,7 +247,7 @@ public virtual unsafe void CommitLogCheckpoint(Guid logToken, byte[] commitMetad
247247
}
248248

249249
/// <inheritdoc />
250-
public virtual unsafe void CleanupLogCheckpoint(Guid logToken)
250+
public unsafe void CleanupLogCheckpoint(Guid logToken)
251251
{
252252
if (removeOutdated)
253253
{

0 commit comments

Comments
 (0)