Fix HELLO output. "proto" field was sent as BulkString which broke clients like redis-py in RESP3 mode.

Author: prvyk

libs/server/Resp/BasicCommands.cs

@@ -1569,8 +1569,8 @@ void ProcessHelloCommand(byte? respProtocolVersion, ReadOnlySpan<byte> username,
                     ("server", "redis"),
                     ("version", storeWrapper.redisProtocolVersion),
                     ("garnet_version", storeWrapper.version),
-                    ("proto", this.respProtocolVersion),
-                    ("id", 63),
+                    ("proto", (long)this.respProtocolVersion),
+                    ("id", Id),
                     ("mode", storeWrapper.serverOptions.EnableCluster ? "cluster" : "standalone"),
                     ("role", storeWrapper.serverOptions.EnableCluster && storeWrapper.clusterProvider.IsReplica() ? "replica" : "master"),
                 ];
@@ -1580,9 +1580,9 @@ void ProcessHelloCommand(byte? respProtocolVersion, ReadOnlySpan<byte> username,
             {
                 while (!RespWriteUtils.TryWriteAsciiBulkString(helloResult[i].Item1, ref dcurr, dend))
                     SendAndReset();
-                if (helloResult[i].Item2 is int intValue)
+                if (helloResult[i].Item2 is long value)
                 {
-                    while (!RespWriteUtils.TryWriteInt32(intValue, ref dcurr, dend))
+                    while (!RespWriteUtils.TryWriteInt64(value, ref dcurr, dend))
                         SendAndReset();
                 }
                 else
@@ -1593,7 +1593,7 @@ void ProcessHelloCommand(byte? respProtocolVersion, ReadOnlySpan<byte> username,
             }
             while (!RespWriteUtils.TryWriteAsciiBulkString("modules", ref dcurr, dend))
                 SendAndReset();
-            while (!RespWriteUtils.TryWriteArrayLength(0, ref dcurr, dend))
+            while (!RespWriteUtils.TryWriteEmptyArray(ref dcurr, dend))
                 SendAndReset();
         }
 

test/Garnet.test/RespTests.cs

@@ -3907,12 +3907,12 @@ public void AsyncTest1()
             {
                 var db = redis.GetDatabase(0);
 
-                int keyCount = 5;
-                int valLen = 256;
-                int keyLen = 8;
+                var keyCount = 5;
+                var valLen = 256;
+                var keyLen = 8;
 
                 List<Tuple<string, string>> data = [];
-                for (int i = 0; i < keyCount; i++)
+                for (var i = 0; i < keyCount; i++)
                 {
                     lastKey = GetRandomString(keyLen);
                     lastValue = GetRandomString(valLen);
@@ -3932,7 +3932,7 @@ public void AsyncTest1()
 
             var expectedNewlineCount = 30; // 30 '\n' characters expected in response
             var response = lightClientRequest.Execute($"hello 3", expectedNewlineCount);
-            ClassicAssert.IsTrue(response.Length is > 180 and < 190);
+            ClassicAssert.IsTrue(response.Length is > 175 and < 190);
 
             // Switch to byte counting in response
             lightClientRequest.countResponseType = CountResponseType.Bytes;