Skip to content

Commit fe6cb1d

Browse files
committed
add NOTES
1 parent b1f3803 commit fe6cb1d

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

libs/cluster/Server/Replication/ReplicationLogCheckpointManager.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ public IDevice GetDevice(CheckpointFileType retStateType, Guid fileToken)
6767

6868
private HybridLogRecoveryInfo ConverMetadata(byte[] checkpointMetadata)
6969
{
70+
// NOTE: this conversion should be simplified after suspending support for the old format which assumed the cookie is stored in the prefix.
7071
var success = true;
7172
HybridLogRecoveryInfo recoveryInfo = new();
7273

@@ -150,8 +151,6 @@ unsafe int GetCookieData(byte[] commitMetadataWithCookie, out long checkpointCov
150151
/// <param name="checkpointMetadata"></param>
151152
public void CommiLogCheckpointSendFromPrimary(Guid logToken, byte[] checkpointMetadata)
152153
{
153-
// TODO: convert is not needed after deprecating old format
154-
// byte commit metadata send from the primary should be following the new unified format
155154
var recoveryInfo = ConverMetadata(checkpointMetadata);
156155
CommitLogCheckpointMetadata(logToken, recoveryInfo.ToByteArray());
157156
}

0 commit comments

Comments
 (0)