Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue when converting from camel case to snake case for python generation #4531

Open
hvuhsg opened this issue Apr 22, 2024 · 3 comments · May be fixed by #4608
Open

Issue when converting from camel case to snake case for python generation #4531

hvuhsg opened this issue Apr 22, 2024 · 3 comments · May be fixed by #4608
Labels
help wanted Issue caused by core project dependency modules or library Python type:bug A broken experience
Milestone
Kiota v2.0

Comments

@hvuhsg
Copy link

hvuhsg commented Apr 22, 2024

I have a parameter that called imageURL
and its converted to image_u_r_l

Also happening for file names, for example notrixSDK becomes notrix_s_d_k.py
@github-project-automation github-project-automation bot moved this to Todo 📃 in Kiota Apr 22, 2024
@hvuhsg hvuhsg changed the title Issue when converting from camel case to lower case for python generation Issue when converting from camel case to snake case for python generation Apr 22, 2024
@baywet baywet added type:bug A broken experience help wanted Issue caused by core project dependency modules or library Python labels Apr 22, 2024
@baywet
Copy link
Member

baywet commented Apr 22, 2024

Hi @hvuhsg
Thanks for reporting this and for using kiota.
The implementation for the Snake casing is here
And the unit tests here

It could be amended to NOT add an underscore if the following character is uppercase.

Is this something you'd be willing to submit a pull request for?

@hvuhsg
Copy link
Author

hvuhsg commented May 6, 2024

Yes, on it!

@hvuhsg hvuhsg linked a pull request May 6, 2024 that will close this issue
Draft
@hvuhsg
Copy link
Author

hvuhsg commented May 6, 2024

Opened a PR:
#4608

@baywet baywet added this to the Kiota v1.15 milestone May 6, 2024
@baywet baywet moved this from Todo 📃 to In Progress 🚧 in Kiota May 6, 2024
@andrueastman andrueastman moved this from In Progress 🚧 to In Review 💭 in Kiota May 13, 2024
@andrueastman andrueastman modified the milestones: Kiota v1.15, Kiota v2.0 May 13, 2024
@rkodev rkodev mentioned this issue Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issue caused by core project dependency modules or library Python type:bug A broken experience
Projects
Kiota
Status: In Review 💭
Milestone
Kiota v2.0
Development

Successfully merging a pull request may close this issue.

Update ToSnakeCase so it wouldn't return "image_u_r_l" for "imageURL" hvuhsg/kiota
3 participants
@andrueastman @baywet @hvuhsg