Skip to content

Use update PlatformBuild/CIsettings to limit recursive downloading #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Jun 10, 2025

Description

Use updated stuart tools to limit recursive downloading from mu repositories.

When a platform identifies submodules through GetRequiredSubmodules()
it previously only contained True/False for specifying the need for
submodules. If True, it would recursively clone all submodules.

This modification allows specifying a CiSettings file containing a
CiSetupSettingsManager instance, and will attempt to only download
the submodules specified in the GetRequiredSubmodules section.

GetDependencies() does not have configuration for this type of scenario.
A Dependency from GetDependencies will always attempt to resolve ALL submodules that are contained in the repo.

This presents a problem when a submodule contains their own dependency as well. The example run into is:

SecurityPkg => libspdm
libspdm => openssl
openssl => gost-engine
gost-engine => libprov

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Local Builds verifying that limited downloading still builds/boots.

Integration Instructions

No integration ncessary.

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Jun 10, 2025
@apop5 apop5 marked this pull request as ready for review July 16, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant