Menu for flame graph and some minor UX improvements (#595)

* inclusive/exclusive samples: two commands instead of using column header name + use CanExecute pattern

* find by name only when single node is selected

* find by name in call tree view only when single node is selected

* goto actions can use selected node

* allow (un)grouping only when something is selected

* allow changing priority when in Memory View + add tooltip to menu item to explain what it is

* allow folding module/item when something is selected

* allow symbols lookup when something is selected

* allow go to source only when single item is selected

* allow to set time range when text box is focused or some nodes are selected

* allow include/exclude only when something is selected

* simplify the Expand/Collapse code

* simplify the Set BackgroundColor code + use the color for menu items

* simplify open events

* remove unused methods, extra empty lines + use expressions for 1 liners

* make the context menu work for Flame Graph tab

* use event which fires sooner

Author: adamsitnik

src/PerfView/StackViewer/CallTreeView.cs

@@ -345,7 +345,7 @@ private int IndexInParent(CallTreeNode node)
     /// <summary>
     /// This is basically a CallTreeNode with extra state (state of expand boxes) associated needed for the viewer 
     /// </summary>
-    public class CallTreeViewNode
+    public class CallTreeViewNode : INotifyPropertyChanged
     {
         [Conditional("DEBUG")]
         public void ValidateTree()
@@ -355,13 +355,19 @@ public void ValidateTree()
 #endif
         }
 
-        public void SetBackgroundColor(System.Drawing.Color color)
+        public string BackgroundColor
         {
-            BackgroundColor = color.Name;
+            get => _backgroundColor;
+            set
+            {
+                if(_backgroundColor != value)
+                {
+                    _backgroundColor = value;
+                    PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(BackgroundColor)));
+                }
+            }
         }
 
-        public string BackgroundColor { get; set; }
-
         /// <summary>
         /// Is the node expanded or not.  
         /// </summary>
@@ -731,6 +737,9 @@ private static int FindChild(ObservableCollectionEx<CallTreeViewNode> flattenedT
         internal bool m_isExpanded;                     // Is this node expanded.  
         private int m_indexGuess;                               // Where we think we are in the flattened tree, may not be accurate but wortch checking  
         internal int m_depth;                           // My nesting level from root.   (root == 0);
+        private string _backgroundColor;
+
+        public event PropertyChangedEventHandler PropertyChanged;
         #endregion
     }
 

src/PerfView/StackViewer/FlameGraphDrawingCanvas.cs

@@ -6,6 +6,7 @@
 using System.Windows.Controls;
 using System.Windows.Input;
 using System.Windows.Media;
+using Microsoft.Diagnostics.Tracing.Stacks;
 using PerfView.Utilities;
 using static PerfView.FlameGraph;
 
@@ -22,13 +23,15 @@ public class FlameGraphDrawingCanvas : Canvas
         private List<Visual> visuals = new List<Visual>();
         private FlameBoxesMap flameBoxesMap = new FlameBoxesMap();
         private ToolTip tooltip = new ToolTip() { FontSize = 20.0 };
+        private CallTreeNode selectedNode;
         private ScaleTransform scaleTransform = new ScaleTransform(1.0f, 1.0f, 0.0f, 0.0f);
         private Cursor cursor;
 
         public FlameGraphDrawingCanvas()
         {
             MouseMove += OnMouseMove;
             MouseLeave += OnMouseLeave;
+            MouseRightButtonDown += (s, e) => selectedNode = flameBoxesMap.Find(e.MouseDevice.GetPosition(this)).Node;
             PreviewMouseWheel += OnPreviewMouseWheel;
             MouseLeftButtonDown += OnMouseLeftButtonDown;
             MouseLeftButtonUp += OnMouseLeftButtonUp;
@@ -38,6 +41,8 @@ public FlameGraphDrawingCanvas()
 
         public bool IsEmpty => visuals.Count == 0;
 
+        public CallTreeNodeBase SelectedNode => selectedNode;
+
         protected override int VisualChildrenCount => visuals.Count;
 
         protected override Visual GetVisualChild(int index) => visuals[index];
@@ -102,7 +107,7 @@ private void OnMouseMove(object sender, MouseEventArgs e)
             if (!IsEmpty && e.LeftButton == MouseButtonState.Released)
             {
                 var position = scaleTransform.Inverse.Transform(Mouse.GetPosition(this));
-                var tooltipText = flameBoxesMap.Find(position);
+                var tooltipText = flameBoxesMap.Find(position).TooltipText;
                 if (tooltipText != null)
                 {
                     ShowTooltip(tooltipText);
@@ -295,7 +300,7 @@ internal void Sort()
                 }
             }
 
-            internal string Find(Point point)
+            internal FlameBox Find(Point point)
             {
                 foreach (var rowData in boxesMap)
                 {
@@ -323,14 +328,14 @@ internal string Find(Point point)
 
                         if (rowData.Value[mid].X <= point.X && point.X <= (rowData.Value[mid].X + rowData.Value[mid].Width))
                         {
-                            return rowData.Value[mid].TooltipText;
+                            return rowData.Value[mid];
                         }
 
-                        return null;
+                        return default(FlameBox);
                     }
                 }
 
-                return null;
+                return default(FlameBox);
             }
 
             private static int CompareByX(FlameBox left, FlameBox right) => left.X.CompareTo(right.X);