Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Many (most?) files don't conform to the project's .editorconfig #2097

Open
leungbk opened this issue Jul 1, 2020 · 1 comment
Open

Many (most?) files don't conform to the project's .editorconfig #2097

leungbk opened this issue Jul 1, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@leungbk
Copy link

leungbk commented Jul 1, 2020

On Linux, with the Editorconfig plugin for Emacs enabled, whenever I make a change inside a .cs file contained in this project, I notice that I generate a lot of ^M characters (when before there were none) unless I set end_of_line = lf in the project's .editorconfig, which currently has end_of_line = crlf.

Based on the .editorconfig, I would have expected all the files to already have ^M characters terminating each line.

@leungbk leungbk added the enhancement New feature or request label Jul 1, 2020
@jakebailey
Copy link
Member

This seems like an interplay between git's choice of line endings and the config, where it's checking it out as LF, not CRLF. We've typically worked on Windows in VS, where git by default will use CRLF when pulling down (so VS would not perceive any problems with formatting).

On Linux, it's likely checking it out as LF so the editorconfig is wrong. Arguably the config should just be removed; the tests normalize things or otherwise don't care about the encoding of their files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants