Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIA notifications are incorrect for git output #18485

Open
Danstiv opened this issue Jan 31, 2025 · 0 comments
Open

UIA notifications are incorrect for git output #18485

Danstiv opened this issue Jan 31, 2025 · 0 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@Danstiv
Copy link

Danstiv commented Jan 31, 2025

Windows Terminal version

Windows Terminal Canary Version: 1.23.10282.0

Windows build number

10.0.22631.4751

Other Software

Git 2.44.0

Steps to reproduce

  1. Download git 2.43 from https://github.com/git-for-windows/git/releases/download/v2.43.0.windows.1/PortableGit-2.43.0-64-bit.7z.exe
  2. Download git 2.44 from https://github.com/git-for-windows/git/releases/download/v2.44.0-rc0.windows.1/PortableGit-2.44.0-rc0-64-bit.7z.exe
  3. Extract downloaded 2.43 and 2.44 versions somewhere.
  4. Open a tab in the windows terminal (cmd or power shell).
  5. cd to the git 2.43/bin directory.
  6. Launch the windows narrator (ctrl+win+enter).
  7. Execute git without arguments.
  8. cd to the git 2.44/bin directory.
  9. Execute git without arguments.

Expected Behavior

Git usage should be spoken without obvious interruptions in the middle of the words in every git version.
At least the word "usage" should be distinctly audible from the Narrator.

Actual Behavior

When using git 2.43 (step 7), behavior is normal and expected, there is no problems.
When using git 2.44 (step 9) The Narrator speaks "u", and then "sage" with a small noticeable pause.
More detailed debugging with the NVDA screenreader showed that after the first character in each line of the git output, an additional line feed (\n) is added, which is not visible on the screen, but is in UIA Notification.
This problem is reproducible on the latest stable version of git for windows 2.47, as well as in latest Windows Terminal Preview.
@carlos-zamora

@Danstiv Danstiv added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

1 participant