Skip to content

Commit 25da717

Browse files
authored
Revert GitHub repo telemetry collection (#1091)
We decided that while this data would be very useful to us, it isn't worth potential privacy concerns.
1 parent 52cefcc commit 25da717

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

include/vcpkg/metrics.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ namespace vcpkg
6060
CommandName,
6161
DeploymentKind,
6262
DetectedCiEnvironment,
63-
GithubRepo,
6463
InstallPlan_1,
6564
ListFile,
6665
ProcessTree,

src/vcpkg/metrics.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,6 @@ namespace vcpkg
133133
{StringMetric::CommandName, "command_name", "z-preregister-telemetry"},
134134
{StringMetric::DeploymentKind, "deployment_kind", "Git"},
135135
{StringMetric::DetectedCiEnvironment, "detected_ci_environment", "Generic"},
136-
{StringMetric::GithubRepo,
137-
"github_repo_hash",
138-
"0000000011111111aaaaaaaabbbbbbbbccccccccddddddddeeeeeeeeffffffff"},
139136
// spec:triplet:version,...
140137
{StringMetric::InstallPlan_1, "installplan_1", plan_example},
141138
{StringMetric::ListFile, "listfile", "update to new format"},

src/vcpkg/vcpkgcmdarguments.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include <vcpkg/base/hash.h>
21
#include <vcpkg/base/json.h>
32
#include <vcpkg/base/system.debug.h>
43
#include <vcpkg/base/system.h>
@@ -685,20 +684,11 @@ namespace vcpkg
685684

686685
void VcpkgCmdArguments::track_environment_metrics() const
687686
{
688-
MetricsSubmission submission;
689687
if (auto ci_env = m_detected_ci_environment.get())
690688
{
691689
Debug::println("Detected CI environment: ", *ci_env);
692-
submission.track_string(StringMetric::DetectedCiEnvironment, *ci_env);
690+
get_global_metrics_collector().track_string(StringMetric::DetectedCiEnvironment, *ci_env);
693691
}
694-
695-
if (auto gh_repo = github_repository.get())
696-
{
697-
auto gh_repo_hash = Hash::get_string_hash(*gh_repo, Hash::Algorithm::Sha256);
698-
Debug::println("Github repo: ", gh_repo_hash);
699-
submission.track_string(StringMetric::GithubRepo, gh_repo_hash);
700-
}
701-
get_global_metrics_collector().track_submission(std::move(submission));
702692
}
703693

704694
Optional<std::string> VcpkgCmdArguments::asset_sources_template() const

0 commit comments

Comments
 (0)