More expressive checks in triplet (#1379)

Author: Thomas1664

include/vcpkg/triplet.h

@@ -78,6 +78,8 @@ namespace vcpkg
 
         Path get_triplet_file_path(Triplet triplet) const;
         bool is_valid_triplet_name(StringView name) const;
+        bool is_community_triplet_path(const Path& triplet_dir) const;
+        bool is_overlay_triplet_path(const Path& triplet_dir) const;
         bool is_valid_triplet_canonical_name(StringView name) const;
     };
 }

src/vcpkg/commands.build.cpp

@@ -1063,15 +1063,15 @@ namespace vcpkg
         const auto& triplet_db = paths.get_triplet_db();
         const auto& triplet_file_path = triplet_db.get_triplet_file_path(triplet);
 
-        if (Strings::starts_with(triplet_file_path, triplet_db.community_triplet_directory))
+        if (triplet_db.is_community_triplet_path(triplet_file_path))
         {
             msg::print(LocalizedString::from_raw(triplet_file_path)
                            .append_raw(": ")
                            .append_raw(InfoPrefix)
                            .append(msgLoadedCommunityTriplet)
                            .append_raw('\n'));
         }
-        else if (!Strings::starts_with(triplet_file_path, triplet_db.default_triplet_directory))
+        else if (triplet_db.is_overlay_triplet_path(triplet_file_path))
         {
             msg::print(LocalizedString::from_raw(triplet_file_path)
                            .append_raw(": ")

src/vcpkg/triplet.cpp

@@ -105,6 +105,16 @@ namespace vcpkg
         return is_valid_triplet_canonical_name(Strings::ascii_to_lowercase(name));
     }
 
+    bool TripletDatabase::is_community_triplet_path(const Path& path) const
+    {
+        return Strings::starts_with(path, community_triplet_directory);
+    }
+
+    bool TripletDatabase::is_overlay_triplet_path(const Path& path) const
+    {
+        return !Strings::starts_with(path, default_triplet_directory) && !is_community_triplet_path(path);
+    }
+
     bool TripletDatabase::is_valid_triplet_canonical_name(StringView name) const
     {
         return Util::any_of(available_triplets, [=](const TripletFile& tf) { return tf.name == name; });