Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gazebo] build failure #30862

Open
agoeckner opened this issue Apr 14, 2023 · 24 comments
Open

[gazebo] build failure #30862

agoeckner opened this issue Apr 14, 2023 · 24 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@agoeckner
Copy link

agoeckner commented Apr 14, 2023

Package: gazebo[bullet,core,dart,ffmpeg,gdal,graphviz,gts,libusb,openal,simbody]:x64-windows -> 2022-01-20#4

Host Environment

  • Host: x64-windows
  • Compiler: MSVC 19.33.31630.0
  • vcpkg-tool version: 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895
    vcpkg-scripts version: b080256 2023-04-14 (8 hours ago)

To Reproduce

vcpkg install gazebo --recurse

Failure logs

-- Downloading https://patch-diff.githubusercontent.com/raw/osrf/gazebo/pull/3211.diff -> gazebo3211.diff...
-- Downloading https://github.com/osrf/gazebo/archive/382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz -> osrf-gazebo-382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from C:\dev\vcpkg\vcpkg-bundle.json
[DEBUG] Failed to open: C:\dev\vcpkg\vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
Downloading https://github.com/osrf/gazebo/archive/382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz
[DEBUG] Trying to hash C:\dev\vcpkg\downloads\osrf-gazebo-382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz.24972.part
[DEBUG] C:\dev\vcpkg\downloads\osrf-gazebo-382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz.24972.part has hash 1ddae39a5e46708d11729786853b199dbf5a8dadf9dfa6a32d82defe820d8721fb51ae22b6f041703bcdc4680fce15adf21c6fa8c3a11413d8b072ac8a8557ee
error: Failed to download from mirror set
error: File does not have the expected hash:
url: https://github.com/osrf/gazebo/archive/382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz
File: C:\dev\vcpkg\downloads\osrf-gazebo-382dcc3f36095a8d79b5bc9c8b8ad346e867c51d.tar.gz.24972.part
Expected hash: 57638cd0b23b5f2bfd32fdc159d6cd77ca34e3bd695c225591979aef4b7271eac93d3706fa1ffa2340f90013267a4171bebe1e4c142f19ad2bf67963dfed627e
Actual hash: 1ddae39a5e46708d11729786853b199dbf5a8dadf9dfa6a32d82defe820d8721fb51ae22b6f041703bcdc4680fce15adf21c6fa8c3a11413d8b072ac8a8557ee
[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(961): 
[DEBUG] Time in subprocesses: 0us
[DEBUG] Time in parsing JSON: 3us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 6302us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 7.3 s (7285671us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):
      
      Failed to download file with error: 1
      If you are using a proxy, please check your proxy setting. Possible causes are:
      
      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.
      
      2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
         set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
         The value set by your proxy might be wrong, or have same `https://` prefix issue.
      
      3. Your proxy's remote server is out of service.
      
      If you've tried directly download the link, and believe this is not a temporary
      download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
      to report this upstream download server failure.
      

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/gazebo/portfile.cmake:7 (vcpkg_from_github)
  scripts/ports.cmake:147 (include)



Additional context

@agoeckner agoeckner added the category:port-bug The issue is with a library, which is something the port should already support label Apr 14, 2023
@MonicaLiu0311
Copy link
Contributor

Confrim, repro locally.

PS E:\vcpkg02> ./vcpkg version
vcpkg package management program version 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895

See LICENSE.txt for license information.

@agoeckner
Copy link
Author

Thank you @MonicaLiu0311 for taking a look at this!

@PhoebeHui
Copy link
Contributor

Related to #24968, it seems gazebo is broken both on windows and Linux.

@agoeckner
Copy link
Author

Thanks, glad people were able to replicate.

@talregev
Copy link
Contributor

talregev commented Nov 9, 2023

For fixing gazebo classic port in needed old version ports:

  • ogre1.12.9
  • qwt 6.1.5

As I understand, vcpkg not support on that.
I already make a vcpkg support to gazebo file with this manifest:
https://github.com/gazebosim/gazebo-classic/blob/gazebo11/deps/vcpkg/manifest/vcpkg.json

I also close to create the new gazebo port.
I only left to release gz-sim7. I have it ready, but it have many problems.
I can release what I have, but I will need help to solve them.

Copy link

github-actions bot commented May 8, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label May 8, 2024
@agoeckner
Copy link
Author

agoeckner commented May 8, 2024 via email

@LilyWangLL LilyWangLL removed the Stale label May 8, 2024
Copy link

github-actions bot commented Nov 4, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Nov 4, 2024
@agoeckner
Copy link
Author

Why close this? It's still an issue.

@talregev
Copy link
Contributor

talregev commented Nov 4, 2024

I agree

@LilyWangLL LilyWangLL removed the Stale label Nov 5, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Nov 5, 2024

The issue was opened in 2023 for gazebo 2022-01-20#4.

Upstream is now hosted at https://github.com/gazebosim/gazebo-classic, last tag gazebo11_11.14.0 from Oct 9, 2023. But the port wasn't updated to a new release.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 5, 2024

And there are zero CI triplets testing that port.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 5, 2024

Maybe this port should get another look with 11.15.0, gazebosim/gazebo-classic#3369 (pending since February!).

@dg0yt
Copy link
Contributor

dg0yt commented Nov 5, 2024

CC @traversaro

@traversaro
Copy link
Contributor

Thanks for the mention @dg0yt !

As mentioned by @talregev in #30862 (comment), gazebo-classic requires and older version of ogre and qwt with respect to the one provided by vcpkg master, and this is not supported by vcpkg. On the Gazebo side, development has been moved to "Modern Gazebo", i.e. "gz sim", and Gazebo Classic is going to be EOL on January 2025, see https://community.gazebosim.org/t/gazebo-classic-end-of-life/2563 , so upstream gazebo-classic will not be updated to support newer ogre and qwt.

Given all of this, the most logical step seems to be to remove/delist the port from the vcpkg main registry (not sure what are the steps as I do not see any other way this can be fixed. Perhaps @talregev and @agoeckner can clarify their use case and how they imagine this issue can be fixed?

@agoeckner
Copy link
Author

I no longer have a use case for this. Just was clarifying that the issue is still unresolved.

@talregev
Copy link
Contributor

talregev commented Nov 11, 2024

@traversaro I added all the new gz dependencies for the new gz-sim gazebo.
The gz-sim is the last port that should add to order to add gazebo for vcpkg. It need more effort that it will install it correctly in vcpkg eco system.
Are you willing to do this effort?

https://github.com/gazebosim/gz-sim

@traversaro
Copy link
Contributor

I think that if you want to add a gz-sim port, it should be named gz-sim and not gazebo for consistency with other package managers (see for example https://repology.org/project/gz-sim/versions vs https://repology.org/project/gazebo/versions).

Are you willing to do this effort?

Sorry, I do not have a use case for gz-sim on vcpkg and I do not have any spare time to work on this.

@traversaro
Copy link
Contributor

@dg0yt it seems to be given the feedback that we can de-list gazebo. It is sufficient to open a PR that deletes the ports/gazebo directory or something else is necessary? Thanks!

@dg0yt
Copy link
Contributor

dg0yt commented Nov 11, 2024

For delisting, it also needs to be removed from versions/baseline.json.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 11, 2024

it should be named gz-sim and not gazebo for consistency with other package managers (see for example https://repology.org/project/gz-sim/versions vs https://repology.org/project/gazebo/versions).

AFAICS there is only ONE package manager using gz-sim. But okay, it is the repo name.

@traversaro
Copy link
Contributor

That is because there are not a lot of package managers packaging it (and some packaging it as gz-sim8 or gz-sim9, that is the CMake package name). My point is that I am not aware of any package manager packaging gz-sim under the gazebo name.

@MonicaLiu0311
Copy link
Contributor

Here is an example that removes the port: #41458.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 12, 2024

So for delisting, we shouldn't forget to also remove the obsolete entries from scripts/ci.baseline.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

7 participants